{{ message }}
Generalized, quasi 3D look-up table#1825
Merged
Merged
Conversation
… class with x and y
bigfooted
reviewed
Nov 21, 2022
…as they're redundant. Added a 3D table unit test case
pcarruscag
requested changes
Nov 22, 2022
…_general_lookup_table
…_general_lookup_table
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…_general_lookup_table
…_general_lookup_table
…el would not be selected properly
…_general_lookup_table
…code/SU2 into feature_general_lookup_table
pcarruscag
reviewed
Dec 14, 2022
…code/SU2 into feature_general_lookup_table
pcarruscag
reviewed
Jan 27, 2023
pcarruscag
left a comment
pcarruscag
left a comment
Member
There was a problem hiding this comment.
Anything else on your side @bigfooted ?
Contributor
pcarruscag
approved these changes
Jan 30, 2023
pcarruscag
left a comment
pcarruscag
left a comment
Member
There was a problem hiding this comment.
Ok you can figure out the order you want to merge things.
LGTM
…_general_lookup_table
bigfooted
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Generalize the variables in the CLookUpTable class for use in general look-up cases (not only progress variable-enthalpy).
Add dimension to CLookUpTable class to allow for quasi-3D interpolation (linear interpolation between two trapezoidal maps stacked in the third dimension).
I added a unit test as a test case with the quasi-3D table to show the correct use of syntax for 3D look-up operations.
Related Work
Can be used in feature_multilayer_perceptron in the CDataDrivenFluid fluid model for look-up operations.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.