Add HDF5 backend support for CGNS in SU2#1500
Conversation
- hdf5 1.12 source copied in cgns - add cgns files from 4.2 to support hdf5 backend - add parallel cgns build detection to meson
MicK7
force-pushed
the
su2_cgns_with_hfd5
branch
from
46bb9fe to
99dd297
Compare
|
It seems that LGTM analysis is using a very old version of meson. Can someone update it ? |
|
Thanks for the update @MicK7, this only affects code in externals right? if so there is no need to worry about LGTM, I think it was using the old build system. |
|
@pcarruscag yes all the modification are in external. It is just that the LGTM C++ if failing because it is too old and can't cope with cmake syntax. Since I mainly copy pasted the source of hdf5 without modification, I don't really want to modify them for maintainability. |
|
My request to update the meson currently used by LGTM C/C++ is to not create issues for other PR is this one goes in. |
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Yep I got that, I was asking to know if I should look at any of the 531 files 😄
LGTM seems fixed.
|
Does this support a type of CGNS that we didn't before? If so can you add a small test? |
|
@pcarruscag I can change one of the existing testcases to have a validation |
3 participants
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
The proposed changes consist in providing an hdf5 enabled cgns library inside SU2.
This is done by embedding the needed hdf5 sources inside the cgns directory.
A basic meson.build file helps with compilation (instead of original cmake).
Related Work
None
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.