{{ message }}
CFVMOutput & Streamwise+spanwise periodic#1290
Merged
Merged
Conversation
TobiKattmann
changed the title
…wise_spanwise_periodic
…wise_spanwise_periodic
…wise_spanwise_periodic
…wise_spanwise_periodic
…vidual FVM outputs.
TobiKattmann
changed the title
TobiKattmann
commented
Jun 5, 2021
Contributor
Author
There was a problem hiding this comment.
Thanks to @danielmayer for these changes
Contributor
Author
|
The CodeFactor issue is the usual Complex Code in CSolver.hpp so it can be discarded. Otherwise I have not really more to add |
pcarruscag
reviewed
Jun 5, 2021
pcarruscag
left a comment
pcarruscag
left a comment
Member
There was a problem hiding this comment.
thanks 👍 few comments below
…rom individual FVM outputs." This reverts commit 43e3690.
pcarruscag
reviewed
Jun 6, 2021
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
pcarruscag
approved these changes
Jun 8, 2021
Contributor
Author
|
Thanks for the review and fixing the mistakes @pcarruscag |
Member
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Hi all,
\file <filename>, i changed that. I renamedCAdjFlowOutput.hpp->CAdjFlowCompOutput.hppas the cpp as that name and that class as well.PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.