{{ message }}
Repository navigation
fix: Connect account onboarding not working in example app - #2662
Closed
MohitR1999 wants to merge 5 commits into
Closed
MohitR1999 wants to merge 5 commits into
MohitR1999 wants to merge 5 commits into
Conversation
Author
|
@guido-stripe Just a gentle nudge 😃 Not a priority issue but it did give me some friction when trying out Stripe's react native SDK. Would be great if you could have a look on this 🙌🏾 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the
exampleapp, the Connect account onboarding journey was not working due to a missing dependency onreact-native-webviewMotivation
The issue was found when I was trying to find a fix for a separate issue. I was trying out the SDK and the example app wherein I realised that this journey was broken. I've raised an issue here: #2661 and explained everything in as much detail as possible
Testing
Documentation
Not required
Select one:
Note:
Original work, no AI tools were used in drafting this PR 😉