{{ message }}
Repository navigation
Require next-major targets for breaking changes - #2855
Open
jar-stripe wants to merge 5 commits into
Open
jar-stripe wants to merge 5 commits into
jar-stripe wants to merge 5 commits into
Conversation
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
jar-stripe
marked this pull request as ready for review
September 18, 2026 20:32
jar-stripe
requested review from
zacchua-stripe
and
a lite review from Copilot
and removed request for
a team
September 18, 2026 20:32
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow correctly scopes permissions, detects new changefiles, and enforces the intended branch target.
Pull request overview
Adds CI enforcement requiring major Hark changefiles to target sdk-release/next-major.
Changes:
- Adds least-privilege workflow permissions and relevant pull request triggers.
- Detects and validates newly added major changefiles.
- Adds a patch changelog entry.
File summaries
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zacchua-stripe
approved these changes
Sep 19, 2026
Comment on lines
+78
to
+82
Contributor
There was a problem hiding this comment.
Same question as stripe/stripe-dotnet#3456 (comment) !
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Breaking SDK changes must land on
sdk-release/next-majorso they do not enter the current major release frommaster.What?
sdk-release/next-major.sdk-release/next-majorintomaster.actionlint, and passes repository CI.See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.