{{ message }}
Reduce flash footprint#91
Merged
Merged
Conversation
Member
Contributor
Author
Replace calls within programRtcWakeUp() function with a custom timeshift calculation to reduce flash size. Signed-off-by: tshcherban <shcherban91@gmail.com> Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
fpistm
approved these changes
May 17, 2023
fpistm
left a comment
fpistm
left a comment
Member
There was a problem hiding this comment.
Hi @tshcherban
I've fixed the astyle issue and also made some code formatting.
I've tested and it works as expected.
I guess to go further the epoch method from RTC could be optimized to not use those API.
Thanks for this improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
gmtimeandmktimecalls withinprogramRtcWakeUpfunction with a custom timeshift calculation.Saves ~15k flash and reduces alarm time calculation duration ~twice.
Fixes #90
FYI: #13, #73