{{ message }}
chore: MP4 wording cleanup + "We Recommend" rename/polish#228
Merged
Conversation
added 2 commits
June 26, 2026 09:47
The video export is just an MP4 export, not specifically a karaoke feature. Replace all "karaoke" references in UI strings, the download filename, comments, docstrings, and docs with neutral MP4/video wording. No behavior change. - UI: MP4 "Export Mix" subtitle -> "Export mix with the original video". - Download filename: <title>_karaoke.mp4 -> <title>_video.mp4 (frontend download attr and backend Content-Disposition). - Comments / docstrings / README updated; no renamed identifiers (downloadCurrentVideo, /video.mp4, has_video were already neutral).
Match the README "We Recommend" section. "Supporters" implied a sponsorship relationship the project explicitly does not have (no money or funding accepted); these are editorial recommendations of makers and artists. Updates the rail button (title/aria-label/chip) and the dialog heading. Internal ids stay friendsBtn/friendsTitle.
thcp
changed the title
- Stack the rail label onto two centered lines ("We" / "Recommend") so it
no longer clips the 40px chip, and swap the TV icon for a heart (both the
rail button and the dialog header).
- Add a monogram avatar fallback: tiles with no image (or a broken image)
render an on-brand circular initial instead of a broken-image icon.
- Add two recommendations: Thomann (@thomann.music) and Analog4Lyfe
(@Analog4Lyfe), in the dialog grid and the README table. Their images
(static/img/friends/{thomann,analog4lyfe}.jpg) can be dropped in later;
until then they show the monogram fallback.
thcp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The video export is just an MP4 export, not specifically a karaoke feature. This removes all "karaoke" wording in favour of neutral MP4/video terms. No behavior change.
User-facing
<title>_karaoke.mp4→<title>_video.mp4(frontenddownloadattr + backendContent-Disposition)Internal (comments / docstrings / docs)
app/api/stems.py,app/core/config.py,app/core/models.py,app/pipeline/download.py,app/pipeline/runner.pystatic/js/main.js,static/js/player.js,tests/test_stems_api.py,README.mdIdentifiers were already neutral (
downloadCurrentVideo,/video.mp4,has_video) — no renames.Verified:
ruff check+ruff format --checkclean, JS syntax OK, 107 tests pass.Also: rename "Supporters" UI label to "We Recommend"
The rail button + dialog said "Supporters", which implies a sponsorship relationship the project explicitly does not have (README: no money/funding accepted; these are editorial recommendations). Renamed to "We Recommend" to match the README section.
title/aria-label/chip text and the dialog<h2>instatic/index.html.friendsBtn/friendsTitle(not user-facing).Also: "We Recommend" polish + new recommendations
@thomann.music) and Analog4Lyfe (@analog4lyfe) to the dialog grid + README table. Their images (static/img/friends/{thomann,analog4lyfe}.jpg) can be added later; they show the monogram until then.