{{ message }}
Repository navigation
refactor(agent): rename not_secret to not_sensitive in [config_env] - #74
Merged
Merged
Conversation
Flagged values now "look sensitive" rather than "look like a credential". Neither name has been released yet.
Checking whether the file exists and then writing it raced with parallel callers: one could create it and set its mode to 000 in between, and the write then failed with "Permission denied". Create it with `create_new` and treat an existing file as fine. Seen as a flaky Ubuntu CI failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73, before it ships in a release.
[config_env]acknowledgement keynot_secret→not_sensitive:agent validatewarning, theagent runmessage and hint, the masked<hidden: looks sensitive>inagent profiles show, and the--config-envhelp.Neither name has been released, so no compatibility alias.
Tested:
cargo testpasses, clippy unchanged.Also fixes a flaky test race when creating the Docker sandbox's blocked shadow file.