{{ message }}
fix(ui): stabilize GCR image integration E2E test#21337
Draft
davdhacs wants to merge 2 commits into
Draft
Conversation
The GCR test asserts that the "New integration" button does not exist, but does so immediately after page visit without waiting for GCR-specific content to render. On GKE with higher latency, the page may not have fully settled before the assertion runs, causing a consistent failure. Wait for the GCR-specific deprecation notice alert before asserting the button's absence. AI-assisted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
The previous fix waited for a deprecation notice alert that may not be rendered in time. Wait for the IntegrationsTable "results found" h2 instead, which confirms the table component (and its button visibility logic) has rendered. AI-assisted change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
integrations/imageIntegrations.testE2E test has a consistently failing assertion for the Google Container Registry (GCR) test case. The test assertscy.get('[data-testid="add-integration"]').should('not.exist')immediately aftervisitIntegrationsTablewithout waiting for GCR-specific content to render.On GKE with higher network latency, the page may not have fully settled before the assertion runs. The
<a>button element (rendered asa.pf-v6-c-button.pf-m-primary) is found in the DOM within the 8s timeout, causing consistent failure.The fix adds a preceding assertion that waits for the GCR-specific deprecation notice alert to appear before asserting the button's absence. This ensures the React component has rendered with the correct route props (
type='google',isCreationDisabled=true) before checking.User-facing documentation
Testing and quality
Automated testing
How I validated my change
The fix adds a gate assertion that waits for the GCR deprecation notice (
cy.get('.pf-v6-c-alert:contains("Deprecation notice")').should('exist')) before checking button absence. This is a standard Cypress pattern for ensuring page state before negative assertions. Will validate on the next GKE E2E run.