Disable sub-shell spawning if running non-interactively by mclasmeier · Pull Request #33 · stackrox/roxie · GitHub
Skip to content

Disable sub-shell spawning if running non-interactively#33

Merged
mclasmeier merged 6 commits into
mainfrom
mc/non-interactively
Jan 19, 2026
Merged

Disable sub-shell spawning if running non-interactively#33
mclasmeier merged 6 commits into
mainfrom
mc/non-interactively

Conversation

@mclasmeier

@mclasmeier mclasmeier commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

This is a preparation for #18.

  • Detect if running non-interactively.
  • If running non-interactively, disable sub-shell spawning (in other words, require --envrc to be specified). These are the two modes of executing the deployer: sub-shell spawning or envrc writing (containing passwords, endpoints, etc.).

My proposal for issue #18 would be to disable the printing of confidential data (passwords, endpoints) if running non-interactively but keep it for convenience when running on a terminal.

Comment thread go.mod Outdated
Comment thread internal/env/env.go
@mclasmeier mclasmeier requested a review from porridge January 13, 2026 14:47

@porridge porridge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks.

Comment thread cmd/deploy.go Outdated
Comment thread cmd/deploy.go Outdated
mclasmeier and others added 3 commits January 19, 2026 09:50
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
@mclasmeier

Copy link
Copy Markdown
Collaborator Author

@mclasmeier mclasmeier merged commit 52ccd79 into main Jan 19, 2026
2 of 4 checks passed
@mclasmeier mclasmeier deleted the mc/non-interactively branch May 18, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants