WIP: Cleanup NICs when migrate from openstack MCM by dergeberl · Pull Request #89 · stackitcloud/machine-controller-manager-provider-stackit · GitHub
Skip to content

WIP: Cleanup NICs when migrate from openstack MCM#89

Open
dergeberl wants to merge 1 commit intomainfrom
removeNicsOnDeletion
Open

WIP: Cleanup NICs when migrate from openstack MCM#89
dergeberl wants to merge 1 commit intomainfrom
removeNicsOnDeletion

Conversation

@dergeberl
Copy link
Copy Markdown
Member

@dergeberl dergeberl commented Jan 22, 2026

How to categorize this PR?

/kind enhancement

/hold
wip
What this PR does / why we need it:

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 22, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Jan 22, 2026

@ske-prow ske-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2026
@dergeberl dergeberl force-pushed the removeNicsOnDeletion branch 2 times, most recently from 355235c to d542196 Compare January 22, 2026 11:07
@dergeberl dergeberl force-pushed the removeNicsOnDeletion branch from d542196 to cf02b5c Compare January 22, 2026 11:31
@ske-prow ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Jan 22, 2026

@dergeberl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-manager-provider-stackit-verify cf02b5c link true /test pull-machine-controller-manager-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ske-prow ske-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Jan 22, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske
Copy link
Copy Markdown

stackit-ske commented Feb 6, 2026

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@ske-prow ske-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2026
@stackit-ske
Copy link
Copy Markdown

stackit-ske commented Feb 21, 2026

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close

/lifecycle rotten

@ske-prow ske-prow Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2026
@stackit-ske
Copy link
Copy Markdown

stackit-ske commented Feb 28, 2026

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten

/close

@ske-prow ske-prow Bot closed this Feb 28, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Feb 28, 2026

@stackit-ske: Closed this PR.

Details

In response to this:

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dergeberl
Copy link
Copy Markdown
Member Author

dergeberl commented Mar 2, 2026

/reopen

@ske-prow ske-prow Bot reopened this Mar 2, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Mar 2, 2026

@dergeberl: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dergeberl
Copy link
Copy Markdown
Member Author

dergeberl commented Mar 2, 2026

/remove-lifecycle rotten

@ske-prow ske-prow Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 2, 2026
nschad
nschad reviewed Mar 2, 2026
View reviewed changes
Comment thread pkg/provider/sdk_client.go

nics := make([]*NIC, 0)
for _, nic := range *res.Items {
nics = append(nics, convertSDKNICtoNIC(&nic))
Copy link
Copy Markdown
Contributor

@nschad nschad Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we use these convertSDKNICtoNIC? I know we did this also for servers but IMO there is really no reason, we could just use the SDK Type.

@stackit-ske
Copy link
Copy Markdown

stackit-ske commented Mar 17, 2026

Our project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@ske-prow ske-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2026
@dergeberl
Copy link
Copy Markdown
Member Author

dergeberl commented Mar 20, 2026

@ske-prow ske-prow Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2026
@dergeberl dergeberl added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dergeberl @stackit-ske @nschad