{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are handling page URL paths. URLs always use forward slash disregards to the underlying system
/.On windows system, the
path.sepwill be\so the logic will not work for URL pathsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the
path.sepis not about URL but rather about file routing/parsing.On windows system, the
page.urlvalue prints\\blog\\author\\dianne-ameter./character(s) with_.trim, nothing happens :pageUrlcontains\\blog\\author\\dianne-ameterinstead ofblog\\author\\dianne-ameter./, so we get :pageUrlParts = [ '\\blog\\author\\dianne-ameter' ]instead of['blog', 'author', 'dianne-ameter'].This causes the blog page to not list any blog posts and all subdirectory routes are skipped/broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting,
Then I guess the root cause of this bug is somewhere before the execution of this code.
The
page.urlshould never have OS specific separators and should always have standard URL forward slash -/.Maybe the code that constructs the original
urlproperty?