refactor(app): deprecate flat API and flatten runtime context by meganetaaan · Pull Request #533 · stack-chan/stack-chan · GitHub
Skip to content

refactor(app): deprecate flat API and flatten runtime context - #533

Draft
meganetaaan wants to merge 2 commits into
developfrom
refactor/issue-512-runtime-context
Draft

refactor(app): deprecate flat API and flatten runtime context#533
meganetaaan wants to merge 2 commits into
developfrom
refactor/issue-512-runtime-context

Conversation

@meganetaaan

Copy link
Copy Markdown
Collaborator

概要

StackchanRuntimeContext の flat compat API に deprecation を付け、capability wrapper の不要な間接呼び出しを整理します。

変更内容

  • StackchanLegacyFlatCapability と flat member に @deprecated JSDoc を追加
  • capability wrapper を runtime / service へ直接委譲
  • NetworkReadyResult を capabilities.ts に一本化
  • void this.#updateFaceHandler を削除
  • docs を namespaced API を primary とする表記に更新

互換性

公開 API shape は維持します。flat API は削除せず、deprecated annotation のみ追加しています。

検証

  • cd firmware && npm run lint: pass
  • cd firmware && npm run test:unit: pass, 31 tests
  • cd firmware && npm run check:architecture: pass, 13 tests
  • cd firmware && npm run check:legacy-names: pass
  • git diff --check: pass

未実施

  • 実機確認
  • test:moddable / build

リリース影響

patch。互換 API は維持しますが、deprecation 告知はリリースノート記載推奨です。

Closes #512
関連 #392 #515

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@meganetaaan

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@meganetaaan

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackchanRuntimeContext の整理(フラット互換APIの非推奨化と責務分割)

1 participant