{{ message }}
Repository navigation
fix(remote): support secure tunnel addresses - #31499
Draft
chunchet-ng wants to merge 1 commit into
Draft
chunchet-ng wants to merge 1 commit into
chunchet-ng wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ELI5
Pasting an HTTPS tunnel URL into server sharing disables link creation today. Editing a paired phone from a LAN address to a secure tunnel also keeps the LAN port. This fixes both so the existing custom-address flow can use a user-managed Cloudflare Tunnel.
What Changed
The sharing validator accepts HTTPS through the existing URL normalizer. A full WSS address without an explicit port uses 443 in mobile editing; explicit ports and saved proxy paths/queries remain intact. Setup docs explain the actual local listener port, stable versus temporary tunnels, and browser versus mobile pairing scope.
Why
Fix the remaining address failures in the existing transport without adding another parser, provider UI, dependency, or wire format.
Linked Issue
Partial implementation of #14039 and #12535. This does not add the dedicated Cloudflare option or resolve every discovery request, so neither issue is marked fixed.
Related work: #14040 by Pierre-Mike and #8999 by LosEcher; complete URL/proxy support already shipped in #9912 and #11383. This small patch was implemented on current main and does not replace or close those contributors' PRs. Mobile Access credentials from #25077 are a separate follow-up.
Visual Proof
Real mobile-web Edit host route, captured in headless Chromium through Playwright CDP with a synthetic paired host. Same input before and after; no real credentials. This is browser evidence, not a native-device claim.
Testing
action_requiredwith zero jobs; maintainer approval is needed before CI can run.AI Disclosure
Implemented with Codex (GPT-6) assistance. No human maintainer approval is claimed.
Review
Checked connected validators, generation and mobile save/reconnect callers. HTTPS is validated before normalization; HTTP, credentials, fragments and invalid hosts/ports stay rejected. Pairing grants, identity checks, E2EE, listener exposure, old-peer compatibility and bare-address editing are retained. No new process/platform path or provider/agent integration is introduced; SSH/headless hosts retain the same advertised-address contract. Work is bounded input normalization, with no background service. Browser layout is unchanged; the mobile hint describes the port behavior.
Author
X/Twitter handle: not provided.
Agent skill upstream boundary
Notes
Draft while remaining validation and contributor coordination are completed. The authenticated tunnel follow-up stays separate. No merge requested and no required check bypassed.
Checklist