Repository navigation
fix(crash-reporting): scope renderer crash evidence - #16313
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe crash-reporting system now assigns renderer breadcrumbs an origin derived from the IPC sender ID. Breadcrumb storage scopes retained entries, coalescing, and snapshots by origin while preserving global breadcrumbs. Renderer and process-gone deduplication keys include renderer identity. Crash reports use origin-filtered breadcrumb snapshots, then remove origin metadata before persistence. Tests cover attribution, isolation, retention, and deduplication behavior. Merge Risk: ⚪ Minimal · up to This localized diagnostics-attribution change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)Full details: Description checkExplanation The description is detailed, focused, and covers the change, motivation, risks, testing, and scope. It omits several template sections, including an explicit Linked Issue value, Visual Proof or N/A, and checklist items, but the core information is complete. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3f73b9bd-a7a8-4ed1-8919-1d8ccbb6b4ca
📒 Files selected for processing (17)
src/main/crash-reporting/crash-breadcrumb-renderer-attribution.test.tssrc/main/crash-reporting/crash-breadcrumb-store.tssrc/main/crash-reporting/crash-report-store.test.tssrc/main/crash-reporting/crash-report-store.tssrc/main/crash-reporting/durable-crash-breadcrumb.tssrc/main/crash-reporting/process-gone-dedupe.test.tssrc/main/crash-reporting/process-gone-dedupe.tssrc/main/crash-reporting/process-gone-recorder.test.tssrc/main/crash-reporting/process-gone-recorder.tssrc/main/index.tssrc/main/ipc/crash-reporting-renderer-breadcrumbs.test.tssrc/main/ipc/crash-reporting-renderer-breadcrumbs.tssrc/main/ipc/crash-reporting-renderer-error-report-attribution.test.tssrc/main/ipc/crash-reporting-renderer-error-report.tssrc/main/ipc/crash-reporting.tssrc/shared/crash-breadcrumb-origin.tssrc/shared/crash-reporting.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.
(cherry picked from commit fba910f)

Summary
Scope renderer crash breadcrumbs and dedupe by the trusted Electron
webContentsIdso one renderer cannot make another renderer's crash look actionable.This is a diagnostics-attribution fix. It does not claim to fix the underlying React #185, renderer OOM, native renderer, or Utility crash causes.
Why
Slack crash triage across 267 reports from 2026-08-20 through 2026-08-24 showed recurring renderer reports whose breadcrumb evidence could be global or sibling-renderer activity. The diagnosis thread is here. This matches the direction of PR #15709 and the React attribution caveat in PR #16153.
Changes
Validation
pnpm test— 6,202 files, 58,274 tests passed; 40 files and 249 tests skipped by suite configuration.pnpm run lint— passed, including code-quality audits, reliability gates, max-lines ratchet, runtime-electron ratchet, skill manifests, and localization checks.pnpm run typecheck— passed.renderer:<id>origin.Risks and scope
Crash triage conclusion
React #185, OOM, generic renderer killed/crashed, and Utility clusters remain historical or inconclusive without a deterministic Orca-owned root cause. This PR improves the evidence needed for the next crash investigation; it is not an underlying crash-rate fix.