{{ message }}
Open
Conversation
Member
Murgeye
force-pushed
the
crawler-logging
branch
from
183cdff to
9e385f4
Compare
Murgeye
force-pushed
the
crawler-logging
branch
from
9e385f4 to
c2cd94f
Compare
Contributor
Author
|
I have updated the PR with the requested changes. |
Member
|
ok. now went through changes. there is lots of noise here AFAICS. lots of redundant information with URLs. i could keep those |
Priyapershad
approved these changes
Oct 20, 2022
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
--crawl, some logging of Connection and TLS errors lacks information (i.e., the current URL or host and port) to be useful. This pull request improves the logging with this additional information.