{{ message }}
Repository navigation
Keep double-quoted DEFAULT values quoted when writing table SQL - #4219
Merged
mgrojo merged 2 commits intoOct 18, 2026
Merged
Conversation
A column default written as DEFAULT "x" is lexed as a QUOTEDLITERAL, which was matched by the generic id grammar rule and stored without its quotes. The generated or exported SQL therefore contained an invalid bare default such as DEFAULT 0000-00-00T00:00:00.000. Split the DEFAULT id rule so that a QUOTEDLITERAL is stored as a properly escaped single-quoted string literal using sqlb::escapeString, while bare identifiers stay as they are. sqlite3_parser.cpp and sqlite3_parser.hpp are regenerated from the grammar with Bison. Fixes sqlitebrowser#4081
mgrojo
approved these changes
Oct 18, 2026
mgrojo
left a comment
mgrojo
left a comment
Member
There was a problem hiding this comment.
This looks good to me. I've just added a pair of test cases which should pass.
mgrojo
enabled auto-merge
October 18, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A column default written as DEFAULT "x" is lexed as a QUOTEDLITERAL, which
was matched by the generic id grammar rule and stored without its quotes.
The generated or exported SQL therefore contained an invalid bare default
such as DEFAULT 0000-00-00T00:00:00.000. Split the DEFAULT id rule so that
a QUOTEDLITERAL is stored as a properly escaped single-quoted string
literal using sqlb::escapeString, while bare identifiers stay as they are.
sqlite3_parser.cpp and sqlite3_parser.hpp are regenerated from the grammar
with Bison.
Fixes #4081