iframe-proxy

karlhorky · 2026-06-26T10:12:02Z

Upgrade to pnpm@11.9.0 and remove pmOnFail: download workaround:

Switch from yarn@1.22.22 to pnpm@11.0.8 #949 (review)
my pnpm issue: pmOnFail does not default to 'download' with devEngines.packageManager pnpm/pnpm#11676
pnpm PR that fixed it: fix(config): apply pmOnFail default to devEngines.packageManager (singular) pnpm/pnpm#11682
pnpm release v11.1.3 that contained the fix: https://github.com/pnpm/pnpm/releases/tag/v11.1.3#:~:text=Fix%20devEngines.packageManager%20(singular%20form%2C%20without%20onFail)%20defaulting%20to%20onFail%3A%20%22error%22%20instead%20of%20the%20documented%20pmOnFail%3A%20%22download%22

coderabbitai · 2026-06-26T10:12:15Z

Warning

`.coderabbit.yaml` has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)

Validation error: Invalid option: expected one of "off"|"warning"|"error" at "reviews.pre_merge_checks.docstrings.mode"

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

📝 Walkthrough

Walkthrough

The pnpm package manager version pin in package.json is updated, and pnpm-workspace.yaml removes the pmOnFail: download block so the trust policy section follows the remaining settings.

Changes

pnpm toolchain settings

Layer / File(s)	Summary
Version pin and workspace policy `package.json`, `pnpm-workspace.yaml`	`devEngines.packageManager.version` is updated to pnpm 11.9.0, and the workspace config removes the `pmOnFail: download` block before `trustPolicy: no-downgrade`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

sql-formatter-org/sql-formatter#949: Updates the same pnpm package-manager pin and workspace behavior in closely related configuration files.

Poem

(_/)
I nibble on pins both old and new,
A pnpm breeze just fluttered through.
One workspace sigh, one version hum,
Then off I hop—bun-bun-bum! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the two main changes: the pnpm version upgrade and removal of the pmOnFail workaround.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch pnpm-11.9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

Upgrades the repository’s pinned pnpm version to 11.9.0 and removes a previously-needed pmOnFail: download workaround from the pnpm workspace configuration.

Changes:

Bump pinned pnpm version in package.json devEngines.packageManager to 11.9.0 (with integrity).
Update pnpm-lock.yaml package-manager dependencies and pnpm package entries to 11.9.0.
Remove pmOnFail: download workaround block from pnpm-workspace.yaml.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pnpm-workspace.yaml	Removes the `pmOnFail: download` workaround configuration.
pnpm-lock.yaml	Updates lock metadata and package-manager dependency entries for pnpm `11.9.0`.
package.json	Updates `devEngines.packageManager.version` to pnpm `11.9.0` (with integrity).

Files not reviewed (1)

pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

karlhorky · 2026-06-26T10:23:47Z

+  pnpm@11.9.0:
+    resolution: {integrity: sha512-vWgtXQP+Ul73yf1ngMaITR51asTJyf4AxTh4KCQxDc+Q493E9Tg18G3669UIXkGFXgvLs7YN4qxburieUDbwOw==}
    engines: {node: '>=22.13'}
    hasBin: true


engines.node would pass this requirement on to consumers, which do not have to run the pnpm version in the package

so I would skip this

karlhorky · 2026-06-26T10:24:13Z

@coderabbitai did I fix the parsing error? if yes, maybe you can update your comment above

coderabbitai · 2026-06-26T10:26:37Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== PR metadata =="
gh pr view 957 --repo sql-formatter-org/sql-formatter --json number,title,headRefName,baseRefName,url

echo
echo "== Review comments by coderabbitai =="
gh api repos/sql-formatter-org/sql-formatter/pulls/957/comments --paginate \
  --jq '.[] | select(.user.login=="coderabbitai") | {id, path, line, body, html_url}'

echo
echo "== Issue comments mentioning parsing by coderabbitai or user =="
gh api repos/sql-formatter-org/sql-formatter/issues/957/comments --paginate \
  --jq '.[] | select((.user.login=="coderabbitai" or .user.login=="karlhorky") and (.body|test("parsing|parse"; "i"))) | {user: .user.login, body, html_url}'

echo
echo "== package.json excerpt =="
sed -n '1,120p' package.json

echo
echo "== pnpm-workspace.yaml =="
sed -n '1,120p' pnpm-workspace.yaml

Length of output: 6038

@karlhorky Yes — based on the current PR state, the parsing issue looks fixed.

The pmOnFail: download block is gone from pnpm-workspace.yaml, and the file now looks syntactically clean. The package.json change also looks fine from what I checked.

One note: GitHub didn’t return any active coderabbitai review comments on this PR, so I don’t see a specific inline comment I can update/resolve right now. If you want, I can re-review the PR from the current state.

coderabbitai · 2026-06-26T10:26:45Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== PR review comments mentioning parsing or pnpm-workspace =="
gh api repos/sql-formatter-org/sql-formatter/pulls/957/comments --paginate \
  --jq '.[] | select((.user.login=="coderabbitai") and ((.body|ascii_downcase|contains("parsing")) or (.path=="pnpm-workspace.yaml") or (.body|ascii_downcase|contains("yaml")))) | {id: .id, path: .path, line: .line, body: .body, url: .html_url}'

echo
echo "== Current pnpm-workspace.yaml =="
nl -ba pnpm-workspace.yaml | sed -n '1,120p'

echo
echo "== Current package.json package manager section =="
rg -n -C2 '"packageManager"|"devEngines"' package.json || true

Length of output: 1114

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Repo root files matching pnpm-workspace.yaml =="
fd -a '^pnpm-workspace\.yaml$' .

echo
echo "== Current pnpm-workspace.yaml =="
cat -n pnpm-workspace.yaml | sed -n '1,120p'

echo
echo "== Current package.json devEngines/packageManager section =="
cat -n package.json | sed -n '1,120p' | rg -n -C2 'devEngines|packageManager|11\.9\.0|11\.0\.8' || true

echo
echo "== PR review comments by coderabbitai on PR `#957` =="
gh api repos/sql-formatter-org/sql-formatter/pulls/957/comments --paginate \
  --jq '.[] | select(.user.login=="coderabbitai") | {id: .id, path: .path, line: .line, body: .body, url: .html_url}'

echo
echo "== PR issue comments by coderabbitai on PR `#957` =="
gh api repos/sql-formatter-org/sql-formatter/issues/957/comments --paginate \
  --jq '.[] | select(.user.login=="coderabbitai") | {id: .id, body: .body, url: .html_url}'

Length of output: 2142

@karlhorky Yes — from what I can see, the parsing issue looks fixed now.

pnpm-workspace.yaml currently has valid-looking YAML structure, and the earlier pmOnFail: download block is gone, so I don't see any remaining syntax there that would obviously trigger a parser error.

nene

Looks good.

Upgrade to pnpm@11.9.0, remove pmOnFail: download config

a904128

karlhorky requested review from Copilot and nene June 26, 2026 10:12

Copilot started reviewing on behalf of karlhorky June 26, 2026 10:12 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Fix CodeRabbit config

e0e02c9

This was referenced Jun 26, 2026

pmOnFail does not default to 'download' with devEngines.packageManager pnpm/pnpm#11676

Closed

Switch from yarn@1.22.22 to pnpm@11.0.8 #949

Merged

nene approved these changes Jun 29, 2026

View reviewed changes

nene merged commit a9528c9 into master Jun 29, 2026
2 checks passed

karlhorky deleted the pnpm-11.9 branch June 29, 2026 19:37

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to pnpm@11.9.0, remove `pmOnFail: download` config#957

Upgrade to pnpm@11.9.0, remove `pmOnFail: download` config#957
nene merged 2 commits into
masterfrom
pnpm-11.9

karlhorky commented Jun 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

`.coderabbit.yaml` has a parsing error

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

karlhorky Jun 26, 2026

Uh oh!

karlhorky commented Jun 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026

Uh oh!

nene left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

karlhorky commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

.coderabbit.yaml has a parsing error

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

karlhorky Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

karlhorky commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026

Uh oh!

nene left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

karlhorky commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

`.coderabbit.yaml` has a parsing error

karlhorky commented Jun 26, 2026 •

edited

Loading