{{ message }}
Remove compiler warnings for spring-security-rsocket#18567
Merged
Conversation
Closes spring-projectsgh-18437 Signed-off-by: jihunparkkk <pjh2996@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: build
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-18437
Changes
compile-warnings-errorjsr305as compileOnly dependency to resolveunknown enum constant When.MAYBEwarning caused by reactor-core/rsocket-core dependenciesBefore
After
Remaining Deprecation Note
AuthenticationPayloadInterceptoruses deprecatedBasicAuthenticationPayloadExchangeConverteras default value.Changing the default to
AuthenticationPayloadExchangeConverterwould resolve this warning, but it may introduce a breaking change since the two converters use different authentication protocols:BasicAuthenticationPayloadExchangeConverter:BASIC_AUTHENTICATION_MIME_TYPEAuthenticationPayloadExchangeConverter: RSocket Authentication ExtensionPlease advise if this change should be included.
Test plan
./gradlew --no-build-cache clean :spring-security-rsocket:check