Add nullability contract to `PasswordEncoder#encode` implementations by scordio · Pull Request #18490 · spring-projects/spring-security · GitHub
Skip to content

Add nullability contract to PasswordEncoder#encode implementations#18490

Merged
rwinch merged 1 commit into
spring-projects:mainfrom
scordio:refine-nullability
Feb 19, 2026
Merged

Add nullability contract to PasswordEncoder#encode implementations#18490
rwinch merged 1 commit into
spring-projects:mainfrom
scordio:refine-nullability

Conversation

@scordio

@scordio scordio commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

This is a follow-up to #18334 (comment).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 13, 2026
@rwinch rwinch self-assigned this Feb 2, 2026
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 2, 2026
@rwinch rwinch added this to the 7.1.0-M2 milestone Feb 2, 2026
@rwinch rwinch enabled auto-merge (rebase) February 2, 2026 19:34
@rwinch

rwinch commented Feb 2, 2026

Copy link
Copy Markdown
Member

@scordio

scordio commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

Oh, I have no idea how I missed it... 😅 Thanks for fixing it!

@rwinch

rwinch commented Feb 2, 2026

Copy link
Copy Markdown
Member

I pushed an empty commit and then removed it to try and get the CI to go, but it appears that this is related to reported GitHub Actions being stuck in the queue for extended periods of times. Once that gets sorted and the build passes this should merge

@scordio

scordio commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

In case raising a fresh PR would make things simpler with the CI, just let me know and I'll do it 🙂

@jgrandja jgrandja modified the milestones: 7.1.0-M2, 7.1.0-M3 Feb 13, 2026
auto-merge was automatically disabled February 15, 2026 14:42

Head branch was pushed to by a user without write access

@scordio

scordio commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

I rebased and squashed everything in a single commit.

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>AbstractValidatingPasswordEncoder.java
@rwinch rwinch enabled auto-merge (rebase) February 19, 2026 20:24
@rwinch rwinch merged commit f8ac095 into spring-projects:main Feb 19, 2026
7 checks passed
@rwinch

rwinch commented Feb 19, 2026

Copy link
Copy Markdown
Member

@scordio scordio deleted the refine-nullability branch February 19, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants