{{ message }}
Repository navigation
Fix JobParameter validation bug in compact constructor - #5050
Merged
Merged
Conversation
- Fixed line 41 to validate 'name' parameter instead of 'value' - The 'name' parameter was previously not validated, allowing null values - This caused potential NullPointerException in equals() and hashCode() methods - Added test case 'testAddingNullJobParameters' to verify the fix Fixes spring-projectsgh-5049 Signed-off-by: mugeon <pos04167@kakao.com>
- Removed testAddingNullJobParameters (indirect test via JobParametersBuilder) - Added testConstructorNameNotNull to directly test name validation - Added testConstructorValueNotNull to directly test value validation - Added testConstructorTypeNotNull to directly test type validation - These tests directly validate the constructor fix Signed-off-by: mugeon <pos04167@kakao.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixed validation bug in
JobParametercompact constructor that validatedvalueparameter twice instead of validating bothnameandvalueparameters.Fixes gh-5049
Problem Description
The compact constructor in
JobParameter.javahad a typo:This allowed creating
JobParameterobjects withnullname, which could cause:NullPointerExceptioninequals()andhashCode()methodsChanges Made
File:
org.springframework.batch.core.job.parameters.JobParameternameinstead ofvalueTesting
spring-javaformat:apply)