{{ message }}
Fix numeric strings being parsed as integers in JSON request bodies#421
Merged
Conversation
Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [9.2.0] Strings of integers are incorrectly parsed as integers
Fix numeric strings being parsed as integers in JSON request bodies
Jul 23, 2025
Member
|
@copilot ensure that other numeric body parameters like |
…ing parameters as strings Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
String parameters containing numeric values were incorrectly converted to JSON numbers instead of remaining as strings when creating API requests. This caused playlist creation to fail when using numeric strings for names or descriptions.
Example issue:
Before (broken):
{"name":2025,"description":2025}❌After (fixed):
{"name":"2025","description":"2025"}✅Root Cause
In
AbstractRequest.bodyParametersToJson(), the code attempted to parse all parameter values as JSON usingJsonParser.parseString(). This converted:"2025"→2025(number)"123.45"→123.45(number)"true"→true(boolean)"null"→null(JSON null)Solution
Modified
bodyParametersToJson()to always treat parameter values as strings usingjsonObject.addProperty(name, value)instead of attempting JSON parsing. This preserves the caller's intent when they explicitly pass string values.Key changes:
JsonParser.parseString()attempt for parameter valuesaddProperty()to ensure values remain as string primitivesTesting
This change ensures string parameters always serialize as JSON strings, preventing API validation failures while maintaining backward compatibility.
Fixes #420.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.