test resources: add file extensions by dflems · Pull Request #132 · spotify/SPTPersistentCache · GitHub
Skip to content

test resources: add file extensions#132

Merged
dflems merged 1 commit into
masterfrom
ext
Aug 9, 2022
Merged

test resources: add file extensions#132
dflems merged 1 commit into
masterfrom
ext

Conversation

@dflems

@dflems dflems commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

These files were extensionless. Added the .dat extension as they're supposed to be regarded as arbitrary binary data.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't get this test to pass locally w/o a little sleep here. maybe my machine is just too fast 💪

@dflems dflems merged commit 94c3244 into master Aug 9, 2022
@codecov

codecov Bot commented Aug 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #132 (e3a481d) into master (130c231) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head e3a481d differs from pull request most recent head aa56de2. Consider uploading reports for the commit aa56de2 to get more accurate results

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   98.65%   98.43%   -0.23%     
==========================================
  Files          14       14              
  Lines         969      896      -73     
==========================================
- Hits          956      882      -74     
- Misses         13       14       +1     
Flag Coverage Δ
ios 98.43% <ø> (-0.23%) ⬇️
macos 98.43% <ø> (-0.23%) ⬇️
tvos 98.43% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/SPTPersistentCacheFileManager.m 92.77% <0.00%> (-1.68%) ⬇️
Sources/SPTPersistentCache.m 98.62% <0.00%> (-0.13%) ⬇️
Sources/SPTPersistentCacheHeader.m 100.00% <0.00%> (ø)
Sources/SPTPersistentCacheGarbageCollector.m 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dflems dflems deleted the ext branch August 9, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants