Xcode 13 support, fix some warnings, remove suppressions by dflems · Pull Request #130 · spotify/SPTPersistentCache · GitHub
Skip to content

Xcode 13 support, fix some warnings, remove suppressions#130

Merged
dflems merged 5 commits into
masterfrom
dflems/20210924-ci
Sep 24, 2021
Merged

Xcode 13 support, fix some warnings, remove suppressions#130
dflems merged 5 commits into
masterfrom
dflems/20210924-ci

Conversation

@dflems

@dflems dflems commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously using a messy dictionary structure for what amounted to 3 properties (likely no worse performance-wise than nested dictionaries)

Comment thread ci/spotify_os.xcconfig
IPHONEOS_DEPLOYMENT_TARGET = 12.0
WATCHOS_DEPLOYMENT_TARGET = 3.0
TVOS_DEPLOYMENT_TARGET = 12.0
MACOSX_DEPLOYMENT_TARGET = 10.12

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update deployment targets

Comment thread ci/spotify_os.xcconfig
WARNING_CFLAGS_XCODE_1000 = -Wno-objc-messaging-id
WARNING_CFLAGS_XCODE_1100 = $(WARNING_CFLAGS_XCODE_1000)
WARNING_CFLAGS_XCODE_1200 = $(WARNING_CFLAGS_XCODE_1000)
WARNING_CFLAGS = -Weverything -Wno-error=deprecated -Wno-objc-missing-property-synthesis -Wno-gnu-conditional-omitted-operand -Wno-gnu -Wno-documentation-unknown-command -Wno-reserved-id-macro -Wno-auto-import -Wno-missing-variable-declarations -Wno-c++98-compat -Werror -Wno-direct-ivar-access -Wno-padded

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove suppression on -Wobjc-messaging-id

@codecov

codecov Bot commented Sep 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #130 (faad32e) into master (974682a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head faad32e differs from pull request most recent head 1b5e24f. Consider uploading reports for the commit 1b5e24f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   97.92%   97.93%           
=======================================
  Files          14       14           
  Lines         965      969    +4     
=======================================
+ Hits          945      949    +4     
  Misses         20       20           
Flag Coverage Δ
ios 97.93% <100.00%> (+<0.01%) ⬆️
macos 97.93% <100.00%> (+<0.01%) ⬆️
tvos 97.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/NSError+SPTPersistentCacheDomainErrors.m 100.00% <ø> (ø)
Sources/SPTPersistentCacheDebugUtilities.m 100.00% <ø> (ø)
Sources/SPTPersistentCacheFileManager.m 94.44% <ø> (ø)
Sources/SPTPersistentCacheGarbageCollector.m 92.59% <ø> (ø)
Sources/SPTPersistentCacheHeader.m 100.00% <ø> (ø)
Sources/SPTPersistentCacheObjectDescription.h 100.00% <ø> (ø)
Sources/SPTPersistentCacheObjectDescription.m 100.00% <ø> (ø)
Sources/SPTPersistentCachePosixWrapper.m 100.00% <ø> (ø)
Sources/SPTPersistentCacheRecord.m 100.00% <ø> (ø)
Sources/SPTPersistentCacheResponse.m 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974682a...1b5e24f. Read the comment docs.

@adamhowardprice

Copy link
Copy Markdown

@dflems dflems merged commit 12f1d72 into master Sep 24, 2021
@dflems dflems deleted the dflems/20210924-ci branch September 24, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants