WIP add functions for creating chamfers and fillets to the NURBS kernel by phkahler · Pull Request #1501 · solvespace/solvespace · GitHub
Skip to content

WIP add functions for creating chamfers and fillets to the NURBS kernel#1501

Draft
phkahler wants to merge 3 commits into
solvespace:masterfrom
phkahler:fillet
Draft

WIP add functions for creating chamfers and fillets to the NURBS kernel#1501
phkahler wants to merge 3 commits into
solvespace:masterfrom
phkahler:fillet

Conversation

@phkahler

Copy link
Copy Markdown
Member

Just an outline at this point (in the code). Hoping to attempt this over the hollidays. Thought people might want to follow along or comment if this goes anywhere.

…ting chamfers and fillets. The function is hooked in Group::Generate but does not modify the shell at this point so it is benign.
@ruevs

ruevs commented Dec 10, 2024

Copy link
Copy Markdown
Member

@phkahler

Copy link
Copy Markdown
Member Author
  • in reality each visible edge is already two coincident edges so the code could "just" move them

Woops you're right. Curves are not duplicated, but there are two TrimBy, one for each surface that meets along a curve. These reference the same underlying curve but one is "backward". So I'll still need to generate 2 new curves, and move both Trims rather than creating a new one. Good news - the PWL points are not in the trims!

Assuming all fillets meeting at a point are the same radius, the surface we want there is spherical. It's really hard to find anything (with google) on spherical NURBS patches, never mind triangular ones. But that's for later. Chamfers first and Fillets with 1 or 2 per vertex. I'm both excited and dreading this...

@ruevs

ruevs commented Dec 11, 2024

Copy link
Copy Markdown
Member

I'm both excited and dreading this...

Indeed :-)

@BKLronin

Copy link
Copy Markdown

I very welcome the attempt to add this. :)

@ruevs ruevs marked this pull request as draft January 24, 2025 13:46
@phkahler

phkahler commented Aug 21, 2025

Copy link
Copy Markdown
Member Author

Getting back to this soon. Here is a sketch to visualize how fillets meet at a corner. Drag the green lines around.
corner_arcs.zip

For equal radius fillets it forms a spherical triangle.
Edit: This is not the new feature demo, it's a line sketch to aid understanding the geometry of corner fillets.

@dodox1

dodox1 commented Dec 28, 2025

Copy link
Copy Markdown

So, is anyone feeling brave enough to pick this up during the days off and actually push the development forward?

@phkahler

Copy link
Copy Markdown
Member Author

@ruevs ruevs force-pushed the master branch 2 times, most recently from 93215ea to bc2bca8 Compare March 28, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants