{{ message }}
C# sample project#1248
Open
TrevorDArcyEvans wants to merge 7 commits into
Open
Conversation
TrevorDArcyEvans
commented
May 24, 2022
TrevorDArcyEvans
commented
- conversion of VB.NET sample to C#
- factored out SolveSpace functionality to a separate file & namespace
- C# project
added 7 commits
May 24, 2022 14:27
Member
Author
|
@phkahler Does it work? LOL! It definitely works ie outputs something to console and doesn't crash. |
ruevs
reviewed
May 25, 2022
| @@ -0,0 +1,369 @@ | |||
| ## Ignore Visual Studio temporary files, build results, and | |||
Member
There was a problem hiding this comment.
Adding such a huge .gitignore seems like bad form to me. One that ignores only the specific files and directories created by VS when building the example is (in my opinion) better. Currently I do not have the C# build tools in my VS installation but I will add them (when I get to my development system) and try the example.
Member
There was a problem hiding this comment.
That is clear from the comment at the top.
Contributor
ruevs
force-pushed
the
master
branch
2 times, most recently
from
93215ea to
bc2bca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.