{{ message }}
Repository navigation
refactor: extract _do_register_agent to eliminate register agent logic redundancy - #19
Merged
smithd36 merged 1 commit intoJun 2, 2026
Conversation
smithd36
approved these changes
Jun 2, 2026
Owner
There was a problem hiding this comment.
Nice refactor. This addresses a significant part of the issue, and _do_register_agent() is a solid extraction.
That said, some duplication still remains since only _handle_register_agent() was updated to use the new helper. _handle_agent_register() continues to implement its own reconnect, validation, registration, and error-handling flow. I view this as more of a broader architectural concern around supporting parallel v1/v2 registration APIs than something that necessarily needs to be fully solved in this PR.
Thanks for the contribution and the help, @cf3901646! Much appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7. Extracted the shared core agent registration logic into a helper method _do_register_agent. This eliminates the duplicate code between _handle_register_agent (v1) and _handle_agent_register (v2) while preserving backwards compatibility.