chore: update README example with non-deprecated function from ioutil by ariyonaty · Pull Request #45 · smallstep/certinfo · GitHub
Skip to content

chore: update README example with non-deprecated function from ioutil#45

Merged
maraino merged 1 commit into
smallstep:masterfrom
ariyonaty:fix/update-deprecated-ioutil-pkg
Jan 2, 2024
Merged

chore: update README example with non-deprecated function from ioutil#45
maraino merged 1 commit into
smallstep:masterfrom
ariyonaty:fix/update-deprecated-ioutil-pkg

Conversation

@ariyonaty

Copy link
Copy Markdown

Small PR to update the example in the README that calls the deprecated ioutil package (as of Go 1.16) with stdlib equivalent os.ReadFile().

A screenshot just for a sanity check:
image

Happy New Year!

@ariyonaty ariyonaty requested a review from a team as a code owner January 1, 2024 22:28
@CLAassistant

CLAassistant commented Jan 1, 2024

Copy link
Copy Markdown

@hslatman hslatman enabled auto-merge January 1, 2024 22:37
@hslatman

hslatman commented Jan 1, 2024

Copy link
Copy Markdown
Member

Thank you, @ariyonaty

@dopey can you merge this? Apparently I don't have the permissions to do so, or maybe the PR was marked as coming from me when allowing the CI run, or something like that.

Signed-off-by: ariyonaty <ariyonaty@users.noreply.github.com>
auto-merge was automatically disabled January 2, 2024 07:02

Head branch was pushed to by a user without write access

@ariyonaty ariyonaty force-pushed the fix/update-deprecated-ioutil-pkg branch from 1f48548 to b9a8d7c Compare January 2, 2024 07:02
@hslatman hslatman enabled auto-merge January 2, 2024 08:43
@hslatman

hslatman commented Jan 2, 2024

Copy link
Copy Markdown
Member

@ariyonaty maybe it's the commit signature not being verified. Can you retry pushing a signed commit?

@maraino maraino disabled auto-merge January 2, 2024 23:04
@maraino maraino merged commit 1764b69 into smallstep:master Jan 2, 2024
@maraino

maraino commented Jan 2, 2024

Copy link
Copy Markdown

@ariyonaty ariyonaty deleted the fix/update-deprecated-ioutil-pkg branch January 3, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants