{{ message }}
fix: remove icon_url from url source block element and plan_id from plan block and update chat stream variable#1822
Merged
Conversation
zimeg
added
bug
zimeg
changed the title
srtaalej
approved these changes
Jan 26, 2026
| async def _flush_buffer(self, chunks: Optional[Sequence[Union[Dict, Chunk]]] = None, **kwargs) -> AsyncSlackResponse: | ||
| """Flush the internal buffer with chunks by making appropriate API calls.""" | ||
| flushings: List[Union[Dict, Chunk]] = [] | ||
| chunks_to_flush: List[Union[Dict, Chunk]] = [] |
Member
There was a problem hiding this comment.
This is a much better name choice and it adds clarity around what will be flushed.
mwbrooks
approved these changes
Jan 26, 2026
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Great work! A nice clean removal of icon_url and plan_id. The refactor to chunks_to_flush also makes the code more readable.
📝 Just a note for our future selves - icon_url and plan_id are internal properties that aren't available on the public API yet. So, there are no breaking changes.
🧪 Test coverage looks great and this has no impact on our sample app. 🚀
| async def _flush_buffer(self, chunks: Optional[Sequence[Union[Dict, Chunk]]] = None, **kwargs) -> AsyncSlackResponse: | ||
| """Flush the internal buffer with chunks by making appropriate API calls.""" | ||
| flushings: List[Union[Dict, Chunk]] = [] | ||
| chunks_to_flush: List[Union[Dict, Chunk]] = [] |
Member
There was a problem hiding this comment.
This is a much better name choice and it adds clarity around what will be flushed.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
icon_urlfrom theurlsource block element to match the expected API and also updates an internalchat_streamvariable for maintenance ongoing.The
plan_idis also removed from the plan block.Testing
Build these changes and stream a message with this app:
Category
/docs(Documents)tests/integration_tests(Automated tests for this library)Notes
No update was made for an
appendwithout either "chunks" or "markdown_text" following discussion of #1809. With logging set to "debug" we might find an alright hint that the buffer is unchanged:Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.