create undocumented message bot events by bruceadowns · Pull Request #1424 · slackapi/java-slack-sdk · GitHub
Skip to content

create undocumented message bot events - #1424

Open
bruceadowns wants to merge 9 commits into
slackapi:mainfrom
bruceadowns:new-message-bot-events
Open

create undocumented message bot events#1424
bruceadowns wants to merge 9 commits into
slackapi:mainfrom
bruceadowns:new-message-bot-events

Conversation

@bruceadowns

@bruceadowns bruceadowns commented Jan 22, 2025

Copy link
Copy Markdown
  • create undocumented message bot events
  • message_bot_add
  • message_bot_remove
  • these occur on add/remove of incoming webhook

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

Bruce Downs
create undocumented message bot events
14066df 
* message_bot_add
* message_bot_remove
* these occur on add/remove of incoming webhook
@bruceadowns
bruceadowns marked this pull request as ready for review January 22, 2025 16:55
@bruceadowns

bruceadowns commented Jan 25, 2025

Copy link
Copy Markdown
Author

@seratch

seratch commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Thanks for taking the time to send this pull request. Let me mention two points:

  • It seems these two subtypes may actually exist but it's not officially listed in the document yet; so at this moment, we're unable to add these changes to SDKs. Our team is communicating with relevant teams on this, so once it's available in the public documents, we can consider adding these classes to this SDK
  • This pull request includes extra changes that are not related to the message event class addition; some of the extra changes seem to be beneficial for this SDK's quality. If you're fine to spend more time, could you revert those changes in this PR and make a different PR for them? We can review it separately

@seratch
seratch marked this pull request as draft February 3, 2025 07:35
@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend labels Feb 3, 2025
@seratch seratch added this to the 1.x milestone Feb 3, 2025
@bruceadowns

bruceadowns commented Feb 3, 2025

Copy link
Copy Markdown
Author

Thank you @seratch, I reverted unrelated changes. I will mark this PR as ready and then wait until your team gets official word. Tests can be added at that time if you choose to go forward.

@bruceadowns
bruceadowns marked this pull request as ready for review February 3, 2025 17:29
@codecov

codecov Bot commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla:signed enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend

Projects

None yet

Milestone

1.x

Development

Successfully merging this pull request may close these issues.

2 participants

@bruceadowns @seratch