{{ message }}
Bugfix: missing hparam type_vocab_size#32
Closed
FFengIll wants to merge 4 commits into
Closed
Conversation
Author
Owner
|
Hi, This seems like a good change. But surely bert.cpp:358 also needs to be changed? Where the hparams are read from the model file |
Author
sure, I will add it. |
FFengIll
commented
Sep 20, 2023
|
|
||
| model.word_embeddings = ggml_new_tensor_2d(ctx, wtype, n_embd, n_vocab); | ||
| model.token_type_embeddings = ggml_new_tensor_2d(ctx, wtype, n_embd, 2); | ||
| model.token_type_embeddings = ggml_new_tensor_2d(ctx, wtype, n_embd, n_vocab_size); |
Author
There was a problem hiding this comment.
@skeskinen
here is a change since the tensor is related to n_vocab_size.
for many case, it is 2, but not a const.
Author
There was a problem hiding this comment.
| int32_t n_intermediate = 1536; | ||
| int32_t n_head = 12; | ||
| int32_t n_layer = 6; | ||
| int32_t n_vocab_size = 2; |
Author
There was a problem hiding this comment.
Here is a break change since new field.
I believe some others will happen in future.
So we may try to shift into GGUF.
FFengIll
commented
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type_vocab_sizeis also a hparam (can not use const as 2).