fix(docs): preserve clipboard activation and validate copied content by waleedlatif1 · Pull Request #9295 · simstudioai/sim · GitHub
Skip to content

fix(docs): preserve clipboard activation and validate copied content - #9295

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/docs-copy-reliability
Oct 21, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/docs-copy-reliability

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep legacy clipboard writes inside a fresh click: prepare Markdown first, then copy it on the next click. Preserve one-click copying when promise-backed clipboard writes are supported.
  • Reject blank Markdown without replacing the clipboard, and verify meaningful exported page content before comparing clipboard bytes.
  • Cover expired user activation, empty responses, retry, and navigation with prepared content. Addresses the two docs review threads in v0.9.31: mothership activity headers, deploy reliability #9292.

Type of Change

  • Bug fix

Testing

  • Pre-fix regression run failed for blank responses and a legacy write after user activation expired.
  • Final production build and browser run passed all 11 navigation/clipboard cases plus the existing HTTP/header checks. JSON reports and screenshots are attached to that run.
  • CI passed, including lint/audits, type checks, and both test shards. Vercel deployment passed; inspected one-click success in the deployed preview.
  • Independent subagent verification, cleanup, test audit, scoped Biome, and diff checks passed. Greptile and Cubic reviewed the final commit without findings. No heavy local build or test suite was run.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The changes since the previous review appear safe to merge.

Summary

The PR rejects blank Markdown and prepares legacy clipboard content for a second click.

  • The docs copy button prepares page text before older browsers need to write it.

Reviews (2) · Last reviewed commit: "fix(docs): isolate clipboard permissions..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b8be2f0 into staging Oct 21, 2026
43 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/docs-copy-reliability branch October 22, 2026 00:46

This branch was successfully deployed

1 active deployment
Preview — 8b5b98a2 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant