iframe-proxy

waleedlatif1 · 2026-10-21T06:14:11Z

Summary

When Turbopack panics on a restored dev cache, desktop-live already empties the cache in its exit trap, but a sticky disk keeps nothing from a job with a failed step, so the clear is discarded and every later run restores the same broken cache and fails the same way
desktop-live now writes a turbopack-cache-broken marker (the Next version) into its uploaded results when the cache broke
New desktop-live-cache-reset job runs only after a failed desktop-live, reads the marker, mounts that dev cache and empties it in a passing job, so the empty cache is what the next run mounts
The key is rebuilt from the run's own event and fork context; the marker only supplies the Next version (validated), so a fork's marker can't name any cache but its own
A desktop-live failure the cache didn't cause leaves no marker and keeps the warm cache
Not in ci's needs: it's maintenance, not a gate

Type of Change

Bug fix

Testing

actionlint on checks.yml: no new findings (the one finding is pre-existing on staging)
Ran the key-resolution step locally against good (16.4.0, 16.5.0-canary.3), hostile (path-like, space-injected, empty) and missing markers: rebuilt key matches the live cache key; hostile markers fail without emitting a key
End-to-end proof is the first staging push after merge: the broken push cache fails desktop-live once, the reset job empties it, and the next run goes green

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-21T06:14:14Z

cubic-dev-ai

1 issue found across 1 file

Confidence score: 3/5

In .github/workflows/checks.yml, startup recovery truncates next_log and loses the marker, so finish may not recognize a later test failure. Preserve the marker in a cache_broken_seen flag and use it in finish.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/checks.yml">

<violation number="1" location=".github/workflows/checks.yml:496">
P2: The marker is lost when startup recovery clears and truncates `next_log`, then a later test failure occurs. Preserve a `cache_broken_seen` flag before truncating the log and use that flag in `finish`, otherwise the failed job can leave the same broken sticky cache for the next run.</violation>
</file>

_{Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-21T06:21:19Z

Confidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The PR lets a passing maintenance job clear a broken desktop-live cache after a failed test job.

A separate job clears the desktop cache after a Turbopack panic.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[desktop-live fails] --> B[Download results]
  B --> C{Broken-cache marker present?}
  C -->|No| D[Keep warm cache]
  C -->|Yes| E[Check version and rebuild cache key]
  E --> F[Mount cache]
  F --> G[Create directory if missing]
  G --> H[Empty cache in passing job]

_{Reviews (4) · Last reviewed commit: "fix(ci): create the dev cache path befor..." · Reviewed by Greptile}

waleedlatif1 · 2026-10-21T06:26:44Z

@greptile

waleedlatif1 · 2026-10-21T06:26:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-21T06:26:52Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 1 file

_{Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-21T06:35:59Z

@greptile

waleedlatif1 · 2026-10-21T06:36:00Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-21T06:36:06Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 2 files

Confidence score: 3/5

In .github/workflows/checks.yml, the reset can erase the shared sticky disk while another desktop-live run is writing it, and that writer can repopulate the cache afterward. Coordinate the reset and writes across refs that share this cache key.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/checks.yml">

<violation number="1" location=".github/workflows/checks.yml:607">
P2: This reset can erase a shared sticky disk while another `desktop-live` run is writing it. Because the key omits the ref but CI concurrency is per ref, a later writer can repopulate the broken cache and defeat this reset; coordinate writers for this cache key.</violation>
</file>

_{Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-21T06:46:39Z

@greptile

waleedlatif1 · 2026-10-21T06:46:40Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-21T06:46:47Z

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic}

fix(ci): reset a broken desktop-live dev cache from a passing job

ebdb3da

cubic-dev-ai Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread .github/workflows/checks.yml Outdated

vercel Bot deployed to Preview October 21, 2026 06:19

View deployment

greptile-apps Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread .github/workflows/checks.yml Outdated

fix(ci): mark a broken dev cache on every panic, not only at exit

2e9d074

vercel Bot deployed to Preview October 21, 2026 06:32

View deployment

cubic-dev-ai Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread .github/workflows/checks.yml

Comment thread .github/workflows/checks.yml

fix(ci): save the emptied dev cache under its own actions/cache entry

241b4c8

cubic-dev-ai Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread .github/workflows/checks.yml Outdated

Comment thread .github/workflows/checks.yml Outdated

vercel Bot deployed to Preview October 21, 2026 06:44

View deployment

fix(ci): create the dev cache path before emptying it on a cache miss

aa0e2ea

cubic-dev-ai Bot reviewed Oct 21, 2026

View reviewed changes

waleedlatif1 merged commit f839cc2 into staging Oct 21, 2026
43 of 44 checks passed

waleedlatif1 deleted the fix/desktop-live-broken-cache-reset branch October 21, 2026 06:50

vercel Bot deployed to Preview October 21, 2026 06:51

View deployment

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

waleedlatif1 commented Oct 21, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

waleedlatif1 commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 21, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 21, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading