{{ message }}
Repository navigation
improvement(mothership): show the worker's display copy for a turn error everywhere it is recorded - #9254
Merged
Conversation
…ror everywhere it is recorded A worker error frame carries a diagnostic `message` and an optional user-facing `displayMessage`. Only the live inline error tag honored `displayMessage`; the server-side error handler recorded `message`, so the persisted transcript, the republished terminal error, the execute API result and the inbox reply all fell back to the diagnostic text, and the client's chat error state did the same. One selector, `mothershipErrorText`, now picks the user-facing text for the tag, the server handler and the client handler, so a reload shows the same line the live turn showed.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messageand an optional user-facingdisplayMessage. Only the live inline error line honoreddisplayMessagemessage, so the persisted transcript (what a reload shows), the republished terminal error that followers and reconnects read, the execute API result and inbox replies all fell back to the diagnostic text, as did the client's chat error statemothershipErrorText, now picks the user-facing text for the inline tag, the server handler and the client handler, so every surface shows the same line the live turn showeddisplayMessage, the fallback order is unchanged (message, thenerror)Type of Change
Testing
messageanddisplayMessagerecordsdisplayMessageas the turn's error (fails on the previous code)lib/mothership/request,lib/mothership/chat, the home stream hooks, message rendering and the copilot chat routes (1628 passed);bun run type-checkfor apps/sim; biome and the relevantcheck:*auditsChecklist