improvement(deps): shared Standard Webhooks verifier, MCP SDK 1.32.1, tiptap 3.31.4 with the prosemirror paste XSS fix by waleedlatif1 · Pull Request #9236 · simstudioai/sim · GitHub
Skip to content

improvement(deps): shared Standard Webhooks verifier, MCP SDK 1.32.1, tiptap 3.31.4 with the prosemirror paste XSS fix - #9236

Merged
waleedlatif1 merged 7 commits into
stagingfrom
chore/deps-followups-2026-10-19
Oct 19, 2026
Merged

improvement(deps): shared Standard Webhooks verifier, MCP SDK 1.32.1, tiptap 3.31.4 with the prosemirror paste XSS fix#9236
waleedlatif1 merged 7 commits into
stagingfrom
chore/deps-followups-2026-10-19

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Standard Webhooks verifier: one verifyStandardWebhook in @sim/security/standard-webhooks (+ verifyStandardWebhookRequest 401 adapter in lib/webhooks/providers/utils.ts) replaces six hand-rolled copies (Clerk, Resend, Linq, Granola, incident.io, Loops) and the svix SDK in the AgentMail receiver; drops svix
    • Each provider keeps its header names, ±300s tolerance, and exact 401 messages; AgentMail still routes by inbox_id and checks exactly one secret
    • Fixes an empty-HMAC-key forgery: a secret like whsec_ / whsec_A decoded to zero bytes, so anyone could sign a delivery
    • Strictens to the documented scheme: only v1, signatures count, secrets must be base64, timestamps must be plain decimal seconds; Loops keeps its own <prefix>_ secret stripping
  • MCP SDK 1.31.0 → 1.32.1 with no behavior change: 1.32 makes the SDK refuse cross-origin redirects itself, so the transport passes redirectPolicy: 'follow' and the OAuth guarded fetch now owns redirects by default (per-hop SSRF check, cross-origin header stripping, cross-origin 307/308 body replay still refused) — outcomes match 1.31 for metadata, token, registration, refresh, and revoke legs; only the auth-type probe opts back into the caller's redirect: 'manual'
  • tiptap 3.30.5 → 3.31.4 with root overrides pinning one copy each of prosemirror-model/view/state/transform, picking up the prosemirror-view paste XSS fix (GHSA-c8x8-7fp4-3x9w, fixed in 1.42.3)
    • parseMarkdown overrides use this.parent (3.31 typed this)
    • Drops our text-input-rule wrapper since tiptap now inserts-then-converts natively (it double-inserted); in collaborative editing the first undo now restores the typed Markdown, a second removes it
    • Keeps the 2-space nested indent under ordered items — upstream's 3-space alignment plus its tokenizer stripping one column less would add a space to fenced code inside numbered items on every save and flip those files to read-only
    • @tiptap/y-tiptap stays at 3.0.7: 3.0.8's move reconciliation drops a peer's concurrent list edits in our two-peer tests
  • pi 1.1 is intentionally not included (needs Pi sandbox image rebuilds coordinated with deploy)

Type of Change

  • Bug fix
  • Improvement

Testing

  • standard-webhooks.test.ts (24, incl. the published Standard Webhooks vector, empty-key forgery, tolerance; each guard reverted → red), provider + AgentMail route tests; helper agreed with svix Webhook.verify on 3000/3000 randomized deliveries before removal
  • transport-redirects.server.test.ts over real loopback servers (SSE redirect, OAuth discovery redirect, token 307 refusal; red without redirectPolicy / with the old 'caller' default) + 46 MCP-related files (464 tests)
  • rich-markdown-editor, file-viewer, collab-doc suites (839 tests) incl. a new fenced-code-in-numbered-list byte-stability regression (red on unpatched list-item); lockfile has a single prosemirror copy
  • Type-check, check:audits, lint, full tests, and e2e run in CI
  • Manual QA worth a pass: link/image input rules + undo (solo and two peers), image resize handles vs Cmd+A, paste from Docs/Word, numbered list with a fenced block stays editable

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 19, 2026 23:18
@gitguardian

gitguardian Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

@vercel

vercel Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 19, 2026 11:58pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 19, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 30 files

This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/mcp/pinned-fetch.ts
Comment thread ...m/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/list-item.ts
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Consolidates seven webhook receivers onto verifyStandardWebhook and updates MCP and editor dependencies.

  • Webhook deliveries share one signature verifier.
  • MCP requests keep guarded redirects after the SDK update.
  • The Markdown editor converts typed syntax and preserves numbered-list code.

No actionable new issues were found.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Provider webhook] --> B[Provider adapter]
  C[AgentMail webhook] --> D[Select workspace by inbox_id]
  B --> E[verifyStandardWebhook]
  D --> E
  E --> F{Headers, timestamp, key and signature valid?}
  F -->|Yes| G[Continue receiver]
  F -->|No| H[Return 401]
Loading

Reviews (3) · Last reviewed commit: "chore(security): drop a duplicated malfo..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the chore/deps-followups-2026-10-19 branch from a884ba9 to ca7d723 Compare October 19, 2026 23:35
@waleedlatif1

waleedlatif1 commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 19, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 30 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

waleedlatif1 commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 force-pushed the chore/deps-followups-2026-10-19 branch from ca7d723 to cea7e36 Compare October 19, 2026 23:51
@waleedlatif1

waleedlatif1 commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 19, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 30 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 074148a into staging Oct 19, 2026
52 of 53 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/deps-followups-2026-10-19 branch October 19, 2026 23:57
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 20, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — cea7e362 Deployed Oct 19, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1