fix(databricks): preserve mutation intent and complete task outputs by waleedlatif1 · Pull Request #9176 · simstudioai/sim · GitHub
Skip to content

fix(databricks): preserve mutation intent and complete task outputs - #9176

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/databricks-review-fixes
Oct 17, 2026
Merged

fix(databricks): preserve mutation intent and complete task outputs#9176
waleedlatif1 merged 2 commits into
stagingfrom
codex/databricks-review-fixes

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve explicit empty Genie descriptions and require a job ID or explicit queued-run cancellation scope.
  • Expose the supported Databricks task variants in job and run outputs, and regenerate integration docs and tool metadata.
  • Classify invalid JSON read from provider responses as provider failures in the shared tool response wrapper, while keeping transform parser bugs internal.

Type of Change

  • Bug fix

Testing

  • 230 focused tests passed in tools/databricks/databricks.test.ts and tools/index.test.ts.
  • New regression cases failed on the pre-fix code for description clearing, unscoped cancellation, and invalid provider JSON.
  • bun run lint, block registry validation, all 60 check:audits, and root bun run type-check passed.
  • Full test suite runs in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown

@waleedlatif1

waleedlatif1 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 17, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/databricks/genie_update_space.ts Outdated
Comment thread apps/sim/tools/databricks/cancel_all_runs.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR preserves explicit Genie description clearing, requires an explicit cancellation scope, and describes more Databricks task outputs.

  • Databricks job and run outputs describe more task types.
  • Genie space updates can clear a description with an empty string.
  • Cancel-all requests require a job or queued-run scope.
  • Invalid provider JSON is labeled as a provider failure.

Reviews (2) · Last reviewed commit: "fix(databricks): preserve blank input an..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the codex/databricks-review-fixes branch from 7817934 to a3683b5 Compare October 17, 2026 17:12
@waleedlatif1

waleedlatif1 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 17, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5848bd5 into staging Oct 17, 2026
44 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/databricks-review-fixes branch October 17, 2026 17:18

This branch was successfully deployed

1 active deployment
Preview — a3683b5a Deployed Oct 17, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1