{{ message }}
Repository navigation
fix(chat): release-audit follow-ups for Project file tabs and sandbox copy parsing - #9169
Merged
Merged
Conversation
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
[Medium impact] The PR appears safe to merge; no blocking issue remains. SummaryThe PR fixes tab reordering, opens Project file tabs in organization chats, and caps sandbox copy bodies.
Reviews (3) · Last reviewed commit: "fix(chat): read a sandbox copy body once..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Parsing a clone of the live stream hung on an oversized body, because cancelling one teed branch waits for the unread other. The copy body is now buffered once at the entry, and both the protocol check and either copy path read that in-memory request.
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
reorderStoredChatResources(same as the client projection), so a chat that stores one tab both unscoped and workspace-addressed (one key under the chat-workspace fallback) can be reordered instead of failing validation. Dropped or unknown resources are still rejectedcopiesBeyondWorkspacesparses the sandbox copy body withv2CopyFileItemsContractunderV2_PARSE_DEFAULTS, the same contract and body cap as the copy route, instead of an uncappedrequest.clone().json(). Oversized or invalid bodies stay on the workspace route and get its normal 413/400projectsis on; the copy-body cap applies to every sandbox copy callbackType of Change
Testing
store.test.ts(twin-tab reorder; dropped/unknown still rejected), streamed 20MB copy body insandbox-resource-transporttests (413 at the cap, not a full read), org-chat Project upsert inhandle-resource-event.test.ts; each failed on the previous codecheck:comment-hygiene,check:source-conventions,check:explicit-any,check:test-patterns,check:api-validation:strict,check:boundariesChecklist
test-auditauthoring gate)