{{ message }}
Repository navigation
fix(slack): serialize Search bot removal with member setup, refuse a custom row on the shared app ID - #8993
Merged
Conversation
…custom row on the shared app ID
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
|
… barriers, assert conflict code
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
5 of 6 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Addresses review findings on the v0.9.21 release PR (#8989) for the Slack member-accounts work (#8979, #8986).
removeSlackSearchInstallationnow runs in a transaction that takeslockOrganizationSlackApp, so an admin removing a Search bot serializes with in-flight member Slack setup like every other Slack Search installation writeslack_approw holding the shared app's ID is refused at member setup start (before OAuth, so the admin sees "This Slack app belongs to another installation owner."), and completion's existingFOR UPDATEread throws aconflictfor one created mid-authorization. Previously member setup also refused, but late and as an unclassified error / generic popup failure; bot setup already had its own pre-check.ensureSharedSlackAppRowstaysON CONFLICT DO NOTHINGType of Change
Testing
slack-shared-member-accounts.integration.ts(real Postgres/Redis): removal waits on the Slack organization lock; member setup refuses a custom row holding the shared app ID at start and (assertingcode: 'conflict') at completion, writing nothing; both lock-contention cases share onewhileOrganizationSlackAppLockedhelper whose barrier is scoped to backends waiting on that lockcheck:api-validation:strict,check:comment-hygiene,check:test-patterns,check:boundaries,check:utilscheck:audits, and integration run in CIChecklist
test-auditauthoring gate)🤖 Generated with Claude Code