{{ message }}
Repository navigation
fix(chat): replace a second stuck transcript reload, and close the cleanup pool in its test - #8990
Merged
Merged
Conversation
…eanup pool in its test A chain of chat-detail reloads cancelled a stuck read at most once and then joined whatever replaced it, so a second hung read held every later reload until the connection closed. Each reload past its hold is now cancelled and replaced, and the replacement holds twice as long, so a hung read is always replaced while a slow one is eventually left to finish. The chat cleanup integration test now also ends the cleanup database pool that collectChatFiles reads through.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbFor('cleanup')pool thatcollectChatFilesreads through, matching the other cleanup-pool suitesType of Change
Testing
handle-resource-event.test.ts: 21/21 pass. New "still replaces a second stuck read … once its doubled hold passes" (cached and first-load) fails on the current staging code (2 failed) and passes with the fix; the existing slow-replacement test still guards against restarting a slow load every holdChecklist
test-auditauthoring gate)