{{ message }}
Repository navigation
chore(db): drop retired storage whose readers have shipped - #8933
Merged
Merged
Conversation
Drops tables and an index whose last readers and writers were removed in already-released versions, makes chat.include_tool_calls NOT NULL, and un-declares six dead columns ahead of a next-release DROP COLUMN. embedding_keyword_tin is dropped by script migration 0031 so it runs after 0030 retires the triggers that still write it on skipped-release upgrades.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 24 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Turn on auto-fix | Re-trigger cubic
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Author
|
@greptile |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
Contributor
There was a problem hiding this comment.
No issues found across 24 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
organization_search_invocation(chore(search): remove legacy indexed enterprise search #8528, v0.9.10),copilot_task_subscriptions(never used by a released Sim or worker version),copilot_workflow_read_hashes(improvement(mothership): restructured stream, tool structures, code typing, file write/patch/append tools, timing issues #4090, v0.6.40),mothership_settings(improvement(mothership): v0.2 #4923, v0.7.0),academy_certificate+academy_cert_status(fix(seo): fix GSC indexing issues, remove unused academy/partners pages #5388, v0.7.22), anddoc_processing_recovery_idx(superseded by the per-connector recovery index in improvement(knowledge): scan processing recovery per connector and prune finished outbox events #8330, v0.9.4)embedding_keyword_tin(fix(db): retire unused keyword search projections #8810, v0.9.17) in script migration0031, not SQL — SQL runs before scripts, so an upgrade that skips 0030's release would otherwise drop the table under its still-installed writer triggers.0030now tolerates the table being gone (db:pushdrops it before the reconciler runs)chat.include_tool_calls→NOT NULL DEFAULT false(closes itscontract-pending(any release)marker). Default, backfill, andSET NOT NULLrun under oneNOWAITlock onchatso a fork copying a legacy null row can't land in between; removed the now-dead?? falsehandling in the chat routes/presenterscopilot_chats.plan_artifact,copilot_messages.parent_message_id/tokens_in/tokens_out,settings.show_training_controls/copilot_enabled_models— v0.9.18's generated inserts still name them, so theirDROP COLUMNis owed next release (contract-pendingmarkers on each table)user,workspace,workflow, ...) fail fast and retry instead of piling up in one transactionLeft alone on purpose: project membership tables (#8590), legacy file-search index tables (#8014),
embedding_searchACL/binary columns andknowledge_projection_dirty(still written by DB triggers).Type of Change
Testing
check:migrations,check:pending-drop-tables,check:schema-mock,check:comment-hygiene,check:test-patterns, block-registry check,bun run lint;drizzle-kit generateis a no-oppackages/db+packages/testing; chat route/deployment + data-drain tests (23 files, 167 tests)migrate/pushprovisioning in CI exercises 0409 + 0031Checklist
test-auditauthoring gate)