{{ message }}
Repository navigation
improvement(tools): delete unreferenced tool response types and the dead generic resource data path - #8596
Merged
Conversation
…ead generic resource data path - delete 168 exported tool *Response types nothing references (mostly umbrella unions) and the 24 local types only they used - add-integration and add-tools templates declare one response type per tool and no umbrella union - drop the never-set genericResourceData chat field; the generic resource panel renders its empty state directly
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 153 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…nse-type guidance
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
This was referenced Oct 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*Responsetypes inapps/sim/tools/*/types.tsthat nothing references — almost all umbrella unions (type XResponse = | XGetResponse | ...) — and the 24 file-local types only those unions used. Types only, no runtime change; generated docs are unchanged (the generator readsexport constoutput properties, which are untouched).add-integrationandadd-toolstemplates now declare one response type per tool and say not to add an umbrella union, so new integrations stop recreating them.genericResourceDatawas never set (chore(lint): delete unused variables and parameters; enforce both rules repo-wide #8554 removed its setter), so every render path ended at an empty list. Drop the chat field and its pass-through props, and reduceGenericResourceContentto the empty state it always rendered;GenericResourceEntry/GenericResourceDatago with it. Thegenericresource type stays (it is in the generated wire contract).check:unused-exportsbaseline shrinks by 165 entries.Type of Change
Testing
bun run lint,bun run type-check,bun run check:audits(58, incl.docs:checkandcheck:unused-exports),docs-manifest:check, block-registry check, home vitest (376), rootbun run testChecklist
test-auditauthoring gate)🤖 Generated with Claude Code