fix(mothership): stop duplicating chat resource tabs in workspace chats by waleedlatif1 · Pull Request #8537 · simstudioai/sim · GitHub
Skip to content

fix(mothership): stop duplicating chat resource tabs in workspace chats - #8537

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/chat-resource-tab-identity
Oct 1, 2026
Merged

fix(mothership): stop duplicating chat resource tabs in workspace chats#8537
waleedlatif1 merged 3 commits into
stagingfrom
fix/chat-resource-tab-identity

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers stamped it unconditionally, so the same workflow/file/table got stored and rendered as two tabs
  • Agent CLI effects now stamp the workspace only in organization chats, matching sandbox-resource-transport
  • open_resource no longer emits workspaceId; the tool executor already stamps the target workspace for organization chats
  • handleResourceSideEffects takes the chat owner and stamps the workspace only in organization chats
  • Existing duplicated rows are left as-is

Type of Change

  • Bug fix

Testing

  • resource-owner.test.ts now asserts a workspace-chat agent effect and open_resource produce the same key as an open tab; it fails on the pre-fix code
  • bun run --cwd apps/sim test on lib/mothership/agent-cli, tools/server/open-resource, tools/registry, request/tools (562 passed); wider lib/mothership + copilot/mothership routes + home stream hooks (3,280 passed)
  • bun run type-check, bun run lint, check:audits (54 audits), docs-manifest:check
  • resources.test.ts covers both owners of handleResourceSideEffects; the workspace-chat case fails with the guard reverted

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Removes workspace ID from resource tab metadata.

The PR appears safe to merge; no outstanding finding or new blocking issue was identified.

Summary

The PR makes workspace-chat resources use an implicit workspace key while retaining explicit workspace addressing for organization chats. The latest revision replaces mock-call assertions in the resource-scope test with assertions on emitted events.

  • Agent CLI effects, open_resource, and tool side effects now follow the chat-owner distinction.
  • No new actionable issue was identified in the changes since the previous review.
Diagram 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Tool[Resource-producing tool] --> Owner{Chat owner}
  Owner -->|Organization| Scoped[Resource with target workspaceId]
  Owner -->|Workspace| Implicit[Resource without workspaceId]
  Scoped --> Effects[Persist and emit resource]
  Implicit --> Effects
Loading

Reviews (3) · Last reviewed commit: "fix(mothership): assert emitted resource..."

greptile-apps[bot]
greptile-apps Bot reviewed Oct 1, 2026
View reviewed changes
Comment thread apps/sim/lib/mothership/request/tools/executor.ts Outdated
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

waleedlatif1 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

greptile-apps[bot]
greptile-apps Bot reviewed Oct 1, 2026
View reviewed changes
Comment thread apps/sim/lib/mothership/request/tools/resources.test.ts Outdated
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

waleedlatif1 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 1, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 045b07c into staging Oct 1, 2026
23 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/chat-resource-tab-identity branch October 1, 2026 20:13
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 1, 2026
Merged

This branch was previously deployed

1 inactive deployment
Preview — 9f74b68d Deployed Oct 1, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1