{{ message }}
Repository navigation
fix(files): stop saving fetched URLs to Files and look names up by the unique index - #8327
Merged
Merged
Conversation
Contributor
|
…ontext URL parses
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
name (N).htmlcopies in the Files rootfetchExternalUrlToWorkspacetofetchExternalUrland removed its save, permission, and upload branchfileNameExistsInWorkspaceFolder,getWorkspaceFileByName) now spell the folder predicate ascoalesce(folder_id, '') = $folder, matching the unique(workspace_id, coalesce(folder_id, ''), original_name)index, so each check is a point lookup. The oldfolder_id IS NULLform made root lookups scan the folder-id indexallocateUniqueWorkspaceFileNameprobes the base name plus(1)…(20), then falls back to a short-id suffix instead of probing up to 1,000 candidates and then failing. The unique index and the existing conflict retry remain the authorityType of Change
Testing
file-names.integration.ts(real Postgres). All three tests fail on the pre-change code:workspace_filesrowcheck:auditspassChecklist