improvement(search): reduce redundant metadata reads by waleedlatif1 · Pull Request #7728 · simstudioai/sim · GitHub
Skip to content

improvement(search): reduce redundant metadata reads - #7728

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-retrieval-reuse
Sep 10, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-retrieval-reuse

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Batch knowledge-base references and tag definitions during search, reducing those reads from 40 statements to 2 for 20 bases while preserving ordering, missing entries, and fresh authorization.
  • Skip GitHub connector discovery for explicitly filtered non-GitHub searches. Keep default/GitHub discovery, ranking, and live access checks unchanged.

Type of Change

  • Performance improvement

Testing

  • 820 unit tests and 62 PostgreSQL integration tests passed, covering ACLs, source/date filters, GitHub access, organization MCP search, and batching parity.
  • Local synthetic benchmark: 480 paired scenario groups; 20-base reference/tag p50 improved from 7.67 ms to 1.91 ms. This measures preparation only; single-base SQL is unchanged.
  • Lint, repository audits, block-registry validation, and docs manifest validation passed. The batching regression is included in the existing PostgreSQL CI job.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@waleedlatif1
waleedlatif1 merged commit 6dba116 into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-retrieval-reuse branch September 10, 2026 10:33

This branch was successfully deployed

1 active deployment
Preview — 5fdc2a56 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant