{{ message }}
Repository navigation
feat(editor): replace canonical input toggle with icon switch - #7527
Merged
Merged
Conversation
Collaborator
|
@j15z can you include a before & after image? |
This was referenced Sep 5, 2026
j15z
changed the title
j15z
marked this pull request as ready for review
September 5, 2026 23:59
Contributor
Greptile SummaryReplaces the canonical input arrow toggle with a reusable, keyboard-accessible two-option icon switch.
Confidence Score: 5/5The PR appears safe to merge; the previous package self-import issue is resolved and no new actionable defects were identified. The current implementation preserves canonical mode behavior while providing native radio selection and keyboard semantics, and the follow-up commit removes the circular package-barrel import without changing runtime behavior.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/icon-switch/icon-switch.tsx | Introduces the reusable radio-based IconSwitch and now uses direct internal imports without a package barrel cycle. |
| packages/emcn/src/components/icon-switch/icon-switch.test.tsx | Covers selection semantics, disabled behavior, and tooltip presentation for pointer and keyboard users. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/canonical-mode-toggle.tsx | Defines the Selector and Variable mode options and adapts the shared switch to the existing canonical toggle callback. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx | Replaces the former arrow button and tooltip with the dedicated CanonicalModeToggle component. |
Reviews (2): Last reviewed commit: "fix(emcn): avoid icon switch package imp..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
j15z
force-pushed
the
codex/canonical-input-icon-switch
branch
from
September 6, 2026 00:10
80dccd1 to
0026901
Compare
Contributor
Author
|
@greptile |
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
This was referenced Sep 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist
Screenshots/Videos
Before:
After:
