feat(oracle-epm-account-reconciliation): add integration by BillLeoutsakosvl346 · Pull Request #7509 · simstudioai/sim · GitHub
Skip to content

feat(oracle-epm-account-reconciliation): add integration - #7509

Closed
BillLeoutsakosvl346 wants to merge 24 commits into
feat/oracle-epm-foundationfrom
investigate/oracle-epm-account-reconciliation-integration
Closed

feat(oracle-epm-account-reconciliation): add integration#7509
BillLeoutsakosvl346 wants to merge 24 commits into
feat/oracle-epm-foundationfrom
investigate/oracle-epm-account-reconciliation-integration

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Add 33 Oracle EPM Account Reconciliation tools covering periods, reconciliation and profile rules, imports, matching lifecycle, users/teams, comments/attachments, and explicit file staging.
  • Add a block with period/file selectors, seven workflow templates, generated documentation and catalog wiring. Reuse the existing Oracle oval and service-account credentials.
  • Stack on feat(oracle-epm): add guarded foundation #7469 (feat/oracle-epm-foundation, 9ec1be01aac6fac1bbacafe14e93f53188f45c1b). Consume its transport, polling, returned-link validation, and bounded file helpers without changing foundation code.

Type of Change

  • New feature
  • Documentation

Testing

  • Added request contracts for all 33 actions plus job, link, file, selector, block, registry and output-contract coverage.
  • Independent read-only validation reviewed the entire integration with the foundation; five integration findings were addressed and re-reviewed.
  • Final-checkpoint Test and Build passed on 02320733c4941759e82fa5ad3f8e6b1afd81c880: lint/audits, all test shards, workspace type checks and application build. Validation was explicitly dispatched for this stacked base. No live Oracle tenant calls were performed.
  • Review focus: Oracle request casing and requiredness, immediate period changes versus opening jobs, accepted-job preservation, artifact/attachment link binding, and operation-specific outputs.

Review status

  • Independent validation completed in three passes; all five integration findings are resolved.
  • Greptile completed one review at 5/5 on 02320733c4941759e82fa5ad3f8e6b1afd81c880; zero review threads remain open.
  • Cubic could not complete a review: both the automatic run and manual retry hit the repository review quota. Its neutral/skipped check is not a completed review. No billing or reviewer settings were changed.

Scope and limitations

  • No foundation or shared-platform behavior changes. Attribute import retains its UI operation and filenames but uses the shorter canonical tool ID oracle_epm_account_reconciliation_import_recon_attributes to meet provider name limits.
  • Generated bookkeeping includes the documentation manifest, docs navigation/icon entries, and the two-selector expected inventory counts.
  • The optional attribute date-format input is excluded because Oracle documents conflicting casing. Reconciliation-rule filter optionality follows current REST prose and EPM Automate documentation. Only documented canonical routes are accepted despite malformed example links.
  • Roles, Transaction Matching availability and Basic-auth/MFA prerequisites remain tenant-dependent and were not live-verified.
  • The existing docs generator emits trailing whitespace/final blank lines, including in this new generated page. Generator output is retained; no unrelated generator repair is included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Bill Leoutsakos added 18 commits September 3, 2026 18:55
Bill Leoutsakos Bill Leoutsakos
feat(oracle-epm): add guarded foundation
287603d
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): harden guarded foundation
7ba3213
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): address follow-up review findings
c000b7b
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): validate raw returned-link paths
5e32a64
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): reject unusable link policies
893d086
Bill Leoutsakos Bill Leoutsakos
fix(credentials): authorize before provider matching
849968a
Bill Leoutsakos Bill Leoutsakos
refactor(oracle-epm): narrow shared infrastructure changes
1a37ec6
Bill Leoutsakos Bill Leoutsakos
refactor(oracle-epm): defer shared tool auth helper
3f631c6
Bill Leoutsakos Bill Leoutsakos
refactor(oracle-epm): keep API contract tests provider-neutral
fa2fc7f
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): clarify credential REST base URL
ad88fb2
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): correct credential authentication docs link
cb8b98a
Bill Leoutsakos Bill Leoutsakos
feat(oracle-epm): support repository-path parameters
b81803b
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): support multiword returned-link relations
a818f7a
Bill Leoutsakos Bill Leoutsakos
test(oracle-epm): cover credential setup guidance
8c5f26c
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): bound DNS waits and validate header values
7840639
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): reject malformed returned-link entries
fbb5a4e
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): validate typed returned-link queries
68df997
Bill Leoutsakos Bill Leoutsakos
fix(oracle-epm): reject raw backslashes before link parsing
9ec1be0
@vercel

vercel Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@greptile-apps

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a complete Oracle EPM Account Reconciliation integration, including 33 operations, credential-bound selectors, bounded file transfer, asynchronous job handling, block configuration, catalog wiring, generated metadata, documentation, and focused contract tests.

  • Adds Reconciliation Compliance and Transaction Matching job operations.
  • Supports repository uploads/downloads and reconciliation attachment retrieval with validated returned links.
  • Adds period and repository-file selectors backed by stored Oracle EPM service-account credentials.
  • Registers the integration across block, tool, OAuth, selector, documentation, and deployment catalogs.
  • Adds request, lifecycle, file, selector, registry, and output-contract coverage.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, registry, or contract failures identified.

The operation payloads, block mappings, credential-bound selectors, job lifecycle, returned-link validation, file limits, output contracts, and catalog registrations are internally aligned and supported by focused tests; no blocking failure remains.

Important Files Changed
Filename Overview
apps/sim/lib/internal/oracle-epm-account-reconciliation/contracts.ts Defines bounded input and response schemas and centralizes safe operation execution and failure projection.
apps/sim/lib/internal/oracle-epm-account-reconciliation/jobs.ts Implements accepted-job preservation, bounded polling, status normalization, and validated artifact projection.
apps/sim/lib/internal/oracle-epm-account-reconciliation/files.ts Implements bounded uploads and downloads, execution-scoped storage, attachment binding, and report lifecycle handling.
apps/sim/lib/internal/oracle-epm-account-reconciliation/routes.ts Declares canonical Oracle endpoint spaces and strict returned-link policies for jobs, artifacts, reports, and attachments.
apps/sim/blocks/blocks/oracle_epm_account_reconciliation.ts Exposes all 33 operations with aligned selectors, canonical fields, execution-time coercions, and conditional outputs.
apps/sim/lib/selectors/server/providers/oracle-epm-account-reconciliation.ts Adds credential-bound period and file selectors with validated provider identity and tenant destination.
apps/sim/tools/oracle_epm_account_reconciliation/types.ts Defines operation parameters and operation-specific public output contracts for the integration.
apps/sim/lib/internal/oracle-epm-account-reconciliation/execute-tool.ts Dispatches every registered Oracle EPM Account Reconciliation tool to its corresponding internal implementation.

Flowchart

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  B[Oracle EPM block] --> M[Operation and parameter mapping]
  M --> T[Registered internal tool]
  T --> V[Input contract validation]
  V --> C[Credential-bound Oracle EPM client]
  C --> O{Operation type}
  O -->|Immediate read/write| R[Validated provider response]
  O -->|Asynchronous job| J[Launch and optionally poll job]
  O -->|Upload or download| F[Bounded file helpers]
  O -->|Selector| S[Periods or repository files]
  J --> L[Validate returned job and artifact links]
  F --> X[Sim execution file storage]
  R --> P[Typed workflow output]
  L --> P
  X --> P
  S --> U[Block selector options]
Loading

Reviews (1): Last reviewed commit: "fix(oracle-epm-account-reconciliation): ..." | Re-trigger Greptile

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the investigate/oracle-epm-account-reconciliation-integration branch from 0232073 to 147f273 Compare September 5, 2026 03:00
@waleedlatif1
waleedlatif1 force-pushed the feat/oracle-epm-foundation branch 4 times, most recently from 840c4f5 to dd493d9 Compare October 8, 2026 15:44
@waleedlatif1
waleedlatif1 deleted the branch feat/oracle-epm-foundation October 8, 2026 18:42
@waleedlatif1
waleedlatif1 deleted the investigate/oracle-epm-account-reconciliation-integration branch October 8, 2026 18:43

This branch was successfully deployed

1 active deployment
Preview — c4672c3a Deployed Oct 3, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BillLeoutsakosvl346 @waleedlatif1