Repository navigation
improvement(settings): accelerate navigation and data loading - #7299
Conversation
Greptile SummaryThe PR accelerates settings navigation by sharing query options between intent prefetching and mounted consumers, hydrating authorized settings data, and improving cache and asynchronous lifecycle handling.
Confidence Score: 5/5The PR appears safe to merge within the eligible follow-up scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/hooks/queries/organization-billing-summary.ts | Defines the shared organization-billing query key, bounded transient retry policy, and remount recovery used by both prefetch and mounted consumers. |
| apps/sim/hooks/queries/utils/prefetch-query-on-intent.ts | Prefetches shared query options and removes only inactive speculative failures without discarding cached data or mounted errors. |
| apps/sim/app/workspace/[workspaceId]/settings/components/billing/billing.tsx | Migrates organization billing to the shared summary query and presents a canonical retry action for terminal errors. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-query-warmers.ts | Maps static settings sections to approved first-content query warmers using the same options as destination pages. |
| apps/sim/app/workspace/[workspaceId]/settings/components/api-keys/api-keys.tsx | Reuses the workspace host context for API-key policy state while preserving existing permission-based creation controls. |
| apps/sim/stores/reset-all-stores.ts | Coordinates clearing identity-scoped client stores and persistence during user transitions. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts | Carries lifecycle ownership through asynchronous workflow execution so delayed cleanup cannot clear replacement state. |
Sequence Diagram
sequenceDiagram
participant U as User
participant N as Settings navigation
participant Q as React Query
participant A as Authorized API
participant P as Settings page
U->>N: Hover or focus destination
N->>Q: Prefetch shared query options
Q->>A: Load authorized first-content data
A-->>Q: Cache projected response
U->>N: Navigate
N->>P: Mount destination
P->>Q: Subscribe with same query key
Q-->>P: Serve cached data
alt Transient request failure
Q->>A: Bounded retry
A-->>Q: Data or terminal error
Q-->>P: Data or retryable error state
end
Reviews (11): Last reviewed commit: "refactor(settings): remove orphan sandbo..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 87 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
a861701 to
c1ec4fa
Compare
|
@greptile |
|
@cubic-dev-ai review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
bdefdf9 to
cacce07
Compare
|
@greptile |
|
@cubic-dev-ai review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@greptile |
|
@cubic-dev-ai review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 111 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
e9903fc to
4aee01e
Compare
|
@greptile |
|
@cubic-dev-ai review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 124 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
4aee01e to
fede7e2
Compare
|
@greptile |
|
@cubic-dev-ai review |
|
@cubic-dev-ai review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 128 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Fix all with cubic | Re-trigger cubic
37e23d9 to
9de6b50
Compare
|
@greptileai please review |
|
@cubic-dev-ai please review |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 125 files
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Fix all with cubic | Re-trigger cubic
9de6b50 to
ea401d4
Compare
|
@greptileai please review |
|
@cubic-dev-ai please review |
There was a problem hiding this comment.
No issues found across 123 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Re-trigger cubic
This branch was successfully deployed
1 participant
Summary
Type of Change
Testing
bun run lintbun run lint:checkbun run apps/sim/scripts/check-block-registry.ts origin/stagingbun run check:audits(40 audits)bun run --cwd apps/sim type-checkagent-stream-docs:generateandskills:syncidempotency checksChecklist