{{ message }}
Repository navigation
fix(secrets): preserve caret when revealing values - #7246
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR preserves editable secret values in the input and applies visual masking while unfocused, avoiding value replacement that moves the caret. It retains fixed-length placeholders for read-only or withheld values and adds focused regression coverage.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified. The editable field now retains its controlled value while applying the same visual masking mechanism already used by sibling secret controls, and read-only or withheld values continue to use fixed-length placeholders.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Type of Change
Testing
Targeted secret-value-field Vitest suite, full lint, block registry checks, 39 repository audits, and docs manifest validation.
Checklist