improvement(ui): consolidate fade-only overflow by waleedlatif1 · Pull Request #7225 · simstudioai/sim · GitHub
Skip to content

improvement(ui): consolidate fade-only overflow - #7225

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/consolidate-fade-truncation
Aug 28, 2026
Merged

improvement(ui): consolidate fade-only overflow#7225
waleedlatif1 merged 1 commit into
stagingfrom
codex/consolidate-fade-truncation

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • standardize shared read-only labels on fade-only overflow with full-value tooltips
  • consolidate chips, selectors, menus, breadcrumbs, previews, and workflow rendering behind shared overflow primitives
  • document the canonical rule and explicit technical, editable, grid, and rich-content exceptions

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run check:audits
  • bun run type-check
  • bun run test
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@waleedlatif1

waleedlatif1 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR standardizes single-line, read-only labels on shared fade-only overflow behavior and full-value tooltips.

  • Adds reusable clipping and menu-label primitives to @sim/emcn.
  • Moves combobox, chip, menu, breadcrumb, preview, and workspace labels onto the shared behavior.
  • Updates workflow-renderer labels while preserving ellipsis for code-preview content.
  • Documents editable, technical, grid, and rich-content exceptions and expands regression tests.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failures identified.

The shared primitives preserve clipping, conditional full-value tooltips, rich-content fallbacks, and existing code-preview truncation, while the updated callers consistently supply the required plain labels.

Important Files Changed
Filename Overview
packages/emcn/src/components/overflow-text/overflow-text.tsx Centralizes hard clipping and conditional edge fading while extending keyboard tooltip targeting to menu items.
packages/emcn/src/components/dropdown-menu/dropdown-menu.tsx Introduces a canonical menu-item label and preserves Radix asChild composition while normalizing plain-text children.
packages/emcn/src/components/combobox/combobox.tsx Moves non-editable visual overlays onto the shared overflow primitive while retaining the interactive layer’s tooltip.
packages/emcn/src/components/chip-dropdown/chip-dropdown.tsx Applies shared fade-only rendering to plain trigger and option labels with a hard-clipped fallback for rich content.
packages/emcn/src/components/chip-select/chip-select.tsx Consolidates trigger and menu option overflow handling without changing selection behavior.
packages/workflow-renderer/src/lib/overflow-span.tsx Routes ordinary renderer labels through shared fade-only overflow while preserving truncation for code previews.
packages/workflow-renderer/src/workflow-block/sub-block-row-view.tsx Removes duplicated truncation classes now owned by the renderer’s shared overflow wrapper.

Reviews (1): Last reviewed commit: "improvement(ui): consolidate fade-only o..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 59b3f37 into staging Aug 28, 2026
20 of 21 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/consolidate-fade-truncation branch August 28, 2026 20:21
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 28, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — e004035e Deployed Aug 28, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1